Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Add manual for pg_result_memory_syze() #145

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

Ippey
Copy link
Contributor

@Ippey Ippey commented Nov 2, 2024

php/doc-en#3972 の変更を取り込みました。

reference/pgsql/version.xml はja側に存在しなかったので、不要だと思いコピーしていません。必要であれば、コピーして作成します。

Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

関数と英語版ドキュメントの作者です。
訳して頂き恐縮です、ありがとうございます!

マージされたPRに改善点があり、メンテナの方がxmlのネストをより良くして下さいました:

php/doc-en@0e3624a

こちらも一緒にすると良いかもしれません。
(リスト要素を段落で括る必要はない、ということだと思います)

Comment on lines 23 to 32
<para>
<variablelist>
<varlistentry>
<term><parameter>result</parameter></term>
<listitem>
&pgsql.parameter.result;
</listitem>
</varlistentry>
</variablelist>
</para>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>
<variablelist>
<varlistentry>
<term><parameter>result</parameter></term>
<listitem>
&pgsql.parameter.result;
</listitem>
</varlistentry>
</variablelist>
</para>
<variablelist>
<varlistentry>
<term><parameter>result</parameter></term>
<listitem>
&pgsql.parameter.result;
</listitem>
</varlistentry>
</variablelist>

Comment on lines 67 to 71
<para>
<simplelist>
<member><function>pg_free_result</function></member>
</simplelist>
</para>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>
<simplelist>
<member><function>pg_free_result</function></member>
</simplelist>
</para>
<simplelist>
<member><function>pg_free_result</function></member>
</simplelist>

@Ippey
Copy link
Contributor Author

Ippey commented Nov 2, 2024

@KentarouTakeda ありがとうございます。修正しました🙏

@KentarouTakeda KentarouTakeda force-pushed the add-pg-result-memory-size branch from e63ed56 to 3685405 Compare November 7, 2024 03:31
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ippey
ありがとうございました!

スタイルを他と統一させて頂いたのと、ヘッダのクレジットにお名前を載せて良いか解らなかったのでひとまず私の名前にしたのですが、ご自身の方が良ければ仰って下さい。

@KentarouTakeda KentarouTakeda merged commit a455860 into php:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants