ext/bcmath: BcMath\Number class
#4187
Conversation
SakiTakamachi
force-pushed
the
bcmath_number
branch
from
a75b307 to
f50378d
Compare
SakiTakamachi
force-pushed
the
bcmath_number
branch
from
f50378d to
3a9547b
Compare
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
@Girgias |
|
Hmm. I don't understand why CI turns red... edit: |
SakiTakamachi
force-pushed
the
bcmath_number
branch
from
c919793 to
6899586
Compare
| </methodsynopsis> | ||
| <simpara> | ||
| Compare two arbitrary precision numbers. | ||
| This method behaves similar to the spaceship operator. |
There was a problem hiding this comment.
Added a link in 10b03c4
reference/bc/bcmath/number/div.xml
Outdated
| </simpara> | ||
| <example> | ||
| <title>Example of <property>BcMath\Number::scale</property> of result object</title> | ||
| <programlisting role="php"> |
There was a problem hiding this comment.
Move the example to the corresponding section, if you want to point it out in the return value you can add an xml:id and link tag
| <!-- ValueError cases --> | ||
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('bcmath-number.add')/db:refsect1[@role='errors']/db:para[1])" /> | ||
| <!-- The DivisionByZeroError case --> | ||
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('bcmath-number.div')/db:refsect1[@role='errors']/db:simpara[1])" /> |
There was a problem hiding this comment.
It might be better to wait for php/doc-base#198 to be merged than using XIncludes with indices
There was a problem hiding this comment.
It was merged a few days ago, and I think there are already published manuals under it. So it's probably safe to start using it now.
| <term><parameter>exponent</parameter></term> | ||
| <listitem> | ||
| <simpara> | ||
| The exponent, as an non-negative and integral (i.e. the scale has to be zero). |
There was a problem hiding this comment.
Use the same wording as in the pow method?
There was a problem hiding this comment.
No, pow accepts the negative exponent
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
I thought I'd commented, but it seems I didn't.... I've fixed everything that needed to be fixed. |
RFCs:
https://wiki.php.net/rfc/support_object_type_in_bcmath
https://wiki.php.net/rfc/fix_up_bcmath_number_class
stub:
https://github.com/php/php-src/blob/master/ext/bcmath/bcmath.stub.php