Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4: CSV related changes and deprecations #4093

Merged
merged 4 commits into from
Nov 19, 2024
Merged

PHP 8.4: CSV related changes and deprecations #4093

merged 4 commits into from
Nov 19, 2024
+217 −219

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 18, 2024

I might have pushed it a bit with the XIncludes and XPath queries.

@Girgias Girgias requested a review from cmb69 November 18, 2024 02:15
cmb69
cmb69 reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have pushed it a bit with the XIncludes and XPath queries.

Yeah, that looks somewhat fragile (e.g. relying on the parameter numbers). Might be better to use some entities here.

reference/filesystem/functions/fgetcsv.xml Outdated Show resolved Hide resolved
@Girgias Girgias mentioned this pull request Nov 19, 2024
Closed
@Girgias
Address review
6df7bc1 
Improve XInclude XPath query
Improve See Also
@Girgias Girgias requested a review from cmb69 November 19, 2024 22:43
cmb69
cmb69 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of xincludes, but this looks quite reasonable. Minor nit below.

reference/strings/functions/str-getcsv.xml Outdated Show resolved Hide resolved
@Girgias @cmb69
American English
5809768 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias
Copy link
Member Author

Girgias commented Nov 19, 2024

I prefer XIncludes to Entities as language-snippets is a pain as a translator IMHO.

@Girgias Girgias merged commit 73007ad into php:master Nov 19, 2024
2 checks passed
@Girgias Girgias deleted the csv-changes branch November 19, 2024 23:11
@cmb69
Copy link
Member

cmb69 commented Nov 19, 2024

I prefer XIncludes to Entities as language-snippets is a pain as a translator IMHO.

That's true.

@Girgias Girgias mentioned this pull request Nov 20, 2024
Open
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 22, 2024
Open
@Girgias Girgias added this to the PHP 8.4 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @cmb69