Skip to content

Use modern markup for E_* constants #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 12, 2024

  • Indicate that E_STRICT is deprecated as of PHP 8.4.0
  • explain the case where E_RECOVERABLE_ERROR can happen
  • E_USER_ERROR should not be used any more.
  • Rewording which removes personalization

Indicate that E_STRICT is deprecated as of PHP 8.4.0, and explain the case where E_RECOVERABLE_ERROR can happen
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good (two nits below).

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias Girgias merged commit cb7c0c0 into php:master Nov 13, 2024
2 checks passed
@Girgias Girgias deleted the error-constant-markup-rework branch November 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants