-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asymmetric Visiblity and Final properties #3828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! (can't really comment on the actual contents)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks quite good now, but a few things to consider.
@Girgias, since this is mostly about aviz (i.e. PHP 8.4), should we track this PR somewhere?
Also, what to do about the <itemizedlist><title>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly markup remarks.
What is the issue here? |
PhD issue. The |
I suppose for the moment just leave it an open a PhD issue, as it should track nesting (because I imagine this being an issue outside of |
I addressed everything above aside from the sentence-per-line bits. That sounds like it's not a formal convention yet, and it's non-trivial to do, so I'd rather hold off until/unless there's some policy decision on it to follow. Anything else to address before we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's not be too picky here. :)
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
(Rebased to try and fix the build.) |
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
</itemizedlist> | ||
<para> | ||
When a class extends another, the child class may redefine | ||
any property that is not <literal>final</literal>. When doing so, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there should be a link to final
keyword here.
Feels like we should add more keywords entities to doc-base/entities/global.ent
First stab at documenting asymmetric visibility and final properties. (Technically final properties came in with hooks, but that's a much bigger task and it does impact aviz, so I included it here.)