Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetric Visiblity and Final properties #3828

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Asymmetric Visiblity and Final properties #3828

merged 13 commits into from
Oct 15, 2024

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Oct 4, 2024

First stab at documenting asymmetric visibility and final properties. (Technically final properties came in with hooks, but that's a much bigger task and it does impact aviz, so I included it here.)

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (can't really comment on the actual contents)

language/oop5/final.xml Outdated Show resolved Hide resolved
language/oop5/properties.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/final.xml Outdated Show resolved Hide resolved
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks quite good now, but a few things to consider.

@Girgias, since this is mostly about aviz (i.e. PHP 8.4), should we track this PR somewhere?

Also, what to do about the <itemizedlist><title>?

language/oop5/properties.xml Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly markup remarks.

language/oop5/final.xml Outdated Show resolved Hide resolved
language/oop5/final.xml Outdated Show resolved Hide resolved
language/oop5/final.xml Outdated Show resolved Hide resolved
language/oop5/properties.xml Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Outdated Show resolved Hide resolved
language/oop5/visibility.xml Show resolved Hide resolved
reference/reflection/reflectionproperty/isprivate.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/isprotected.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionproperty/ispublic.xml Outdated Show resolved Hide resolved
@Girgias
Copy link
Member

Girgias commented Oct 13, 2024

Thank you! This looks quite good now, but a few things to consider.

@Girgias, since this is mostly about aviz (i.e. PHP 8.4), should we track this PR somewhere?

Please add it to the milestone, I added it to the milestone, and I will create an issue the moment I finish the migration guide.

Also, what to do about the <itemizedlist><title>?

What is the issue here?

@Girgias Girgias added this to the PHP 8.4 milestone Oct 13, 2024
@cmb69
Copy link
Member

cmb69 commented Oct 13, 2024

Also, what to do about the <itemizedlist><title>?

What is the issue here?

PhD issue. The <title> is always rendered as <h1>, so is practically useless.

@Girgias
Copy link
Member

Girgias commented Oct 13, 2024

Also, what to do about the <itemizedlist><title>?

What is the issue here?

PhD issue. The <title> is always rendered as <h1>, so is practically useless.

I suppose for the moment just leave it an open a PhD issue, as it should track nesting (because I imagine this being an issue outside of <itemizedlist>).

@Crell
Copy link
Contributor Author

Crell commented Oct 15, 2024

I addressed everything above aside from the sentence-per-line bits. That sounds like it's not a formal convention yet, and it's non-trivial to do, so I'd rather hold off until/unless there's some policy decision on it to follow.

Anything else to address before we merge this?

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's not be too picky here. :)

@Crell
Copy link
Contributor Author

Crell commented Oct 15, 2024

(Rebased to try and fix the build.)

language/oop5/final.xml Outdated Show resolved Hide resolved
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
</itemizedlist>
<para>
When a class extends another, the child class may redefine
any property that is not <literal>final</literal>. When doing so,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be a link to final keyword here.

Feels like we should add more keywords entities to doc-base/entities/global.ent

@Girgias Girgias merged commit 16f66c0 into php:master Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants