Skip to content

Update ext/session role attributes #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2022
Merged

Update ext/session role attributes #1987

merged 1 commit into from
Dec 11, 2022

Conversation

kocsismate
Copy link
Member

Based on php/php-src#9901

@Girgias
Copy link
Member

Girgias commented Nov 10, 2022

I'm fine with all the similar changes, but could they wait until after PHP 8.2 is released? Don't want to overwhelm translations with QA changes when more important stuff should be worked on.

@kocsismate
Copy link
Member Author

kocsismate commented Nov 10, 2022 •
edited
Loading

I'm fine with all the similar changes, but could they wait until after PHP 8.2 is released? Don't want to overwhelm translations with QA changes when more important stuff should be worked on.

Yeah, Christoph also suggested to wait (#1978 (review)) so I'll postpone the merge of these PRs!

@kocsismate kocsismate requested review from cmb69 and Girgias December 8, 2022 07:29
@kocsismate
Copy link
Member Author

Can I start merging these PRs today, or should I wait a little bit more?

cmb69
cmb69 reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I start merging these PRs today, or should I wait a little bit more?

@Girgias, @saundefined, @mumumu, what do you think?

@mumumu
Copy link
Member

mumumu commented Dec 8, 2022

No problem :)

@Girgias
Copy link
Member

Girgias commented Dec 8, 2022

Eh, go for it, this shouldn't break the build. :)

@kocsismate kocsismate merged commit 601f6f4 into php:master Dec 11, 2022
@kocsismate kocsismate deleted the role-session branch December 11, 2022 15:06
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@kocsismate @claudepache
Update ext/session role attributes (php#1987)
cf0f490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
method synopsis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocsismate @Girgias @mumumu @cmb69