Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $cwd argument to Process creation chain #325

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

TravisCarden
Copy link
Collaborator

@TravisCarden TravisCarden commented Feb 13, 2024

This enables the direct setting of the current working directory ($env) via the constructor and invocation methods of the Process creation chain (which cannot currently be accomplished by any other means):

  • AbstractProcessRunner::run()
  • ProcessFactory::create().*
  • Process::__construct()*
  • SymfonyProcessFactory::create()

* Lost in the original PR and pushed separately: b616b4c

@TravisCarden TravisCarden added enhancement New feature or request bc break Includes API changes that may require updates in client code labels Feb 13, 2024
@TravisCarden TravisCarden added this to the v2.0.0 milestone Feb 13, 2024
@TravisCarden TravisCarden merged commit 439d50f into php-tuf:develop Feb 13, 2024
10 checks passed
@TravisCarden TravisCarden deleted the feature/process-runner-cwd branch February 13, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc break Includes API changes that may require updates in client code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant