Skip to content

Update CI PHP and Symfony versions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 4, 2022
Merged

Update CI PHP and Symfony versions #59

merged 7 commits into from
Feb 4, 2022

Conversation

rvanlaak
Copy link
Member

@rvanlaak rvanlaak commented Feb 3, 2022

No description provided.

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 3, 2022

@bocharsky-bw As you can see in the test run of this PR https://github.com/php-translation/symfony-storage/runs/5052426726?check_suite_focus=true the common package still seems to cause troubles

@bocharsky-bw
Copy link
Member

Uh oh... I see now.. Actually, the master branch of common repo isn't finished yet, was started by @odolbeau and contains a lot of "unreleased" changes. I'm not sure I understand what's going on in that branch to finish all the work, so I hope @odolbeau could help finishing it and release 4.x some day. For now, I ported some good changes that were merged into master including Symfony 6 support and I'm going to release 3.2.0 there - should do the trick and unblock this PR. Thanks for head ups!

@bocharsky-bw
Copy link
Member

@rvanlaak It's better now but still one build failed, could you handle it please?

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bocharsky-bw bocharsky-bw merged commit 764ef98 into master Feb 4, 2022
@bocharsky-bw bocharsky-bw deleted the env-updates-ci branch February 4, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants