Skip to content

CSFixer diff-format is always udiff since 3.0 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2022
Merged

CSFixer diff-format is always udiff since 3.0 #58

merged 3 commits into from
Feb 3, 2022

Conversation

rvanlaak
Copy link
Member

@rvanlaak rvanlaak commented Feb 3, 2022

@rvanlaak rvanlaak requested a review from bocharsky-bw February 3, 2022 09:14
@bocharsky-bw
Copy link
Member

Looks like the config file was renamed as well

@bocharsky-bw
Copy link
Member

For the reference, see similar PR: php-translation/common#45

@rvanlaak
Copy link
Member Author

rvanlaak commented Feb 3, 2022

@bocharsky-bw ready for review and merge

@rvanlaak rvanlaak requested a review from bocharsky-bw February 3, 2022 12:38
bocharsky-bw
bocharsky-bw approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with Makefile 👍

Thank you for fixing it!

@bocharsky-bw bocharsky-bw merged commit 5223456 into master Feb 3, 2022
@bocharsky-bw bocharsky-bw deleted the cs-fixer-3 branch February 3, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvanlaak @bocharsky-bw