Use a different image for PHP CS Fixer to get latest and upgrade config #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5285d20.
|
Config is the same, I just ported it to the newest format, but now PHP CS Fixer drops a lot of backslashes in front of functions. I'm not sure if we should tweak the config, or keep these changes. Any thoughts? |
|
Well, PHP CS Fixer works... and is something internal in this repo. About backslashes - I double-checked Symfony source code and Symfony does not use backslashes for those dropped functions as well, but some are still used e.g. for |
|
Great job @bocharsky-bw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
friendsofphp/php-cs-fixeris ancient: v2.18.3. I hope the new image will use the latest version