Skip to content

Add some documentation about extraction #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

odolbeau
Copy link
Member

@odolbeau odolbeau commented Jan 8, 2020

Add some documentation regarding extraction.

Fix php-translation/symfony-bundle#228

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor misprint tweak, but this is a great improvement for this chapter 👍

@@ -62,8 +62,8 @@ Below is an example of configuration that is great to start with.
excluded_names: ["*TestCase.php", "*Test.php"]
excluded_dirs: [cache, data, logs]

With the configuration above you may extract all translation key from your source
code by running
With the configuration above you may extract all translation keys from your
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bocharsky-bw I also corrected this file according to your comment as I copy pasted the first part of the symfony / extraction documentation from here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bocharsky-bw
Copy link
Member

Thank you, Olivier, for adding missing docs to this section!

@bocharsky-bw bocharsky-bw merged commit 993bd22 into php-translation:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherit existing translations
2 participants