added missing unit-tests

Author: wachterjohannes

composer.json

@@ -29,6 +29,11 @@
             "Task\\TaskBundle\\": "src"
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "Task\\TaskBundle\\Tests": "tests"
+        }
+    },
     "extra": {
         "branch-alias": {
             "dev-master": "1.0-dev"

tests/Functional/BootstrapTest.php

@@ -9,7 +9,7 @@
  * with this source code in the file LICENSE.
  */
 
-namespace Functional;
+namespace Task\TaskBundle\Tests\Functional;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Task\Scheduler\TaskSchedulerInterface;
@@ -18,6 +18,9 @@
 use Task\TaskBundle\Entity\TaskExecutionRepository;
 use Task\TaskBundle\Entity\TaskRepository;
 
+/**
+ * Tests the service definitions.
+ */
 class BootstrapTest extends KernelTestCase
 {
     public function testBootstrap()

tests/Functional/TaskHandlerFactoryTest.php renamed to tests/Functional/Handler/TaskHandlerFactoryTest.php

@@ -9,11 +9,15 @@
  * with this source code in the file LICENSE.
  */
 
-namespace Functional;
+namespace Task\TaskBundle\Tests\Functional\Handler;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Task\Handler\TaskHandlerNotExistsException;
 use Task\TaskBundle\Handler\TaskHandlerFactory;
 
+/**
+ * Functional tests for task-handler definitions.
+ */
 class TaskHandlerFactoryTest extends KernelTestCase
 {
     /**
@@ -29,8 +33,15 @@ protected function setUp()
         $this->taskHandlerFactory = self::$kernel->getContainer()->get('task.handler.factory');
     }
 
-    public function testRun()
+    public function testCreate()
     {
         $this->assertInstanceOf(\TestHandler::class, $this->taskHandlerFactory->create(\TestHandler::class));
     }
+
+    public function testCreateNotExists()
+    {
+        $this->setExpectedException(TaskHandlerNotExistsException::class);
+
+        $this->taskHandlerFactory->create(\stdClass::class);
+    }
 }

tests/Unit/DependencyInjection/HandlerCompilerPassTest.php

@@ -0,0 +1,62 @@
+<?php
+
+/*
+ * This file is part of php-task library.
+ *
+ * (c) php-task
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Unit\DependencyInjection;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\DependencyInjection\Reference;
+use Task\TaskBundle\DependencyInjection\HandlerCompilerPass;
+
+/**
+ * Tests for class HandlerCompilerPass.
+ */
+class HandlerCompilerPassTest extends \PHPUnit_Framework_TestCase
+{
+    public function testProcess()
+    {
+        $container = $this->prophesize(ContainerBuilder::class);
+
+        $container->has(HandlerCompilerPass::REGISTRY_ID)->willReturn(true);
+        $container->findTaggedServiceIds(HandlerCompilerPass::HANDLER_TAG)->willReturn(
+            ['service1' => [], 'service2' => []]
+        );
+        $container->getDefinition('service1')->willReturn(new Definition(\stdClass::class));
+        $container->getDefinition('service2')->willReturn(new Definition(self::class));
+
+        $serviceDefinition = $this->prophesize(Definition::class);
+        $container->findDefinition(HandlerCompilerPass::REGISTRY_ID)->willReturn($serviceDefinition);
+
+        $compilerPass = new HandlerCompilerPass();
+        $compilerPass->process($container->reveal());
+
+        $serviceDefinition->replaceArgument(
+            0,
+            [\stdClass::class => new Reference('service1'), self::class => new Reference('service2')]
+        )->shouldBeCalled();
+    }
+
+    public function testProcessNoTaggedService()
+    {
+        $container = $this->prophesize(ContainerBuilder::class);
+
+        $container->has(HandlerCompilerPass::REGISTRY_ID)->willReturn(true);
+        $container->findTaggedServiceIds(HandlerCompilerPass::HANDLER_TAG)->willReturn([]);
+
+        $serviceDefinition = $this->prophesize(Definition::class);
+        $container->findDefinition(HandlerCompilerPass::REGISTRY_ID)->willReturn($serviceDefinition);
+
+        $compilerPass = new HandlerCompilerPass();
+        $compilerPass->process($container->reveal());
+
+        $serviceDefinition->replaceArgument(0, [])->shouldBeCalled();
+    }
+}

tests/Unit/EventListener/RunListenerTest.php

@@ -9,12 +9,15 @@
  * with this source code in the file LICENSE.
  */
 
-namespace Unit\EventListener;
+namespace Task\TaskBundle\Tests\Unit\EventListener;
 
 use Symfony\Component\EventDispatcher\Event;
 use Task\Runner\TaskRunnerInterface;
 use Task\TaskBundle\EventListener\RunListener;
 
+/**
+ * Tests for class RunListener.
+ */
 class RunListenerTest extends \PHPUnit_Framework_TestCase
 {
     public function testRun()

tests/Unit/Handler/TaskHandlerFactoryTest.php

@@ -0,0 +1,60 @@
+<?php
+
+/*
+ * This file is part of php-task library.
+ *
+ * (c) php-task
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Task\TaskBundle\Tests\Unit\Handler;
+
+use Task\Handler\TaskHandlerInterface;
+use Task\Handler\TaskHandlerNotExistsException;
+use Task\TaskBundle\Handler\TaskHandlerFactory;
+
+/**
+ * Tests for class TaskHandlerFactory.
+ */
+class TaskHandlerFactoryTest extends \PHPUnit_Framework_TestCase
+{
+    public function testCreate()
+    {
+        $handler = new TestHandler();
+        $taskHandlerFactory = new TaskHandlerFactory([TestHandler::class => $handler]);
+
+        $this->assertEquals($handler, $taskHandlerFactory->create(TestHandler::class));
+    }
+
+    public function testCreateNotExists()
+    {
+        $this->setExpectedException(TaskHandlerNotExistsException::class);
+
+        $taskHandlerFactory = new TaskHandlerFactory([TestHandler::class => new TestHandler()]);
+
+        $taskHandlerFactory->create(\stdClass::class);
+    }
+
+    public function testCreateNoHandler()
+    {
+        $this->setExpectedException(TaskHandlerNotExistsException::class);
+
+        $taskHandlerFactory = new TaskHandlerFactory([]);
+
+        $taskHandlerFactory->create(\stdClass::class);
+    }
+}
+
+class TestHandler implements TaskHandlerInterface
+{
+    /**
+     * {@inheritdoc}
+     */
+    public function handle($workload)
+    {
+        return strrev($workload);
+    }
+}
+