Fix variable named function calls

[kkmuffme]

Fix for:

$my_function = 'foo_bar';
$my_function();

[szepeviktor]

Thank you!
Please use count() === 0 or === []

[kkmuffme]

In addition to the !empty check? or instead of? (not possible, since this will cause a PHP notice)

[szepeviktor]

Okay. Then please add a test that fails without this PR.

[kkmuffme]

Sorry, no idea how to do that, I'm not a developer.
The example I provided above will fail without this PR.

[szepeviktor]

TBH This codebase has many-many problems.
I carry this baby only for WP stubs. Please understand that.

[szepeviktor]

Indeed parts property does not exist.

property_exists($node->expr->name, 'parts') &&

[szepeviktor]

No! Working on it...
https://github.com/nikic/PHP-Parser/blob/a6e34665fd6a2bcefc924cb5fd73788767ae510e/lib/PhpParser/Node/Expr/FuncCall.php#L10-L11

[szepeviktor]

Please use $node->expr->name instanceof Name &&
That does the actual check.

[szepeviktor]

Thank you for opening this PR!

[kkmuffme]

Even when doing $node->expr->name instanceof Name && there is no guarantee $parts exists.
And that is the problem. In case of dynamic function this $parts part is null.

The way I did is the fast way to ensure we don't get any notice from there and it will not fail silently.
If you want, I can do the $node->expr->name instanceof Name && property_exists($node->expr->name, 'parts') check, but this is just unnecessarily slower than an !empty check.
Just let me know your preference.

[szepeviktor]

this is just unnecessarily slower than an !empty check

Please take a look at empty's source code in the C code of PHP.

Let's go with Name and we'll see what the future holds.
https://github.com/nikic/PHP-Parser/blob/a6e34665fd6a2bcefc924cb5fd73788767ae510e/lib/PhpParser/Node/Name.php#L26

[kkmuffme]

Changed it now, so it's ready to merge.