[RoadRunner] Add support for RoadRunner 2023 and 2024 #172
Remove spiral/roadrunner dependency
- Loading branch information
commit a0d0a5e3e5e51e116c4264b30e7921e96dc2587c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have really a min requirement to 2.2 and 3.5.1? Or can we go with
"^2 || ^3". Keep the versions wide as possible makes upgrading for others mostly easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-schranz
3.x - Starting from version 3.5.0, support for RoadRunner 2024.1 has been added. Versions below this will only support RoadRunner 2023.3.12 and earlier. I wanted to ensure support for 2024. If ensuring support for 2024 is not necessary, the version can be downgraded to 3.0.
2.x - Version 2.x is required to support RoadRunner 2.x. I added 2.2 because it was the latest 2.x version, released on November 30, 2022. I assumed that users have been using it for a long time. However, we can downgrade to 2.0 if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From library perspective we should keep it as open as possible if we don't require a newer version we should keep it in our range aslong as possible. This make it easier for projects adopting lib updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense, changed to ^2.0 || ^3.0.