Skip to content

CI: switch to GH Actions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented May 9, 2021

Fixes #15

Composer/Ant: move the build scripts to the Composer configuration

As this is a PHP project and the build steps are relatively simple, it will make it more intuitive for contributors to use Composer scripts to run CI checks, than to have to install Ant for this.

This commit creates the same build/CI scripts as were previously available via Ant in the Composer configuration file.

Notes:

  • The scripts are set up to respect the PHP version used by Composer (instead of a system default).
  • The scripts are set up to work equally well on Linux/Windows/Mac.
  • The only two differences are:
    • The mkdir and file deletions won't automatically be done anymore.
      Generally speaking, the mkdir should only need to be run once anyway and the file deletes should not be necessary as the log files will just be overwritten by the tools, so I deemed this an acceptable trade-off.
    • The colors argument won't be set anymore.
      For most tools, this means, the tool will default to automatically determining whether the CLI used supports colourized output.
      As the determination of this in most tools has become pretty good, I, again, deemed this an acceptable trade-off.

CI: switch to GitHub Actions - step 1: code style sniffing

This commit:

  • Adds a GH Actions workflow for the code style CI check which was previously run on Travis.
  • Removes that part of the .travis.yml configuration.
  • Updates the .gitattributes file.
  • Adds a separate badge for the CS workflow to the README.

CI: switch to GitHub Actions - step 2: linting and tests

This commit:

  • Adds a GH Actions workflow for the PHP lint and unit test CI checks which were previously run on Travis.
  • Removes the, now redundant, .travis.yml configuration.
  • Updates the .gitattributes file.
  • Updates the "Build Status" badge in the Readme to use the results from the GH Test Actions runs.

jrfnl added 3 commits May 9, 2021 14:18
As this is a PHP project and the build steps are relatively simple, it will make it more intuitive for contributors to use Composer scripts to run CI checks, than to have to install Ant for this.

This commit creates the same build/CI scripts as were previously available via Ant in the Composer configuration file.

Notes:
- The scripts are set up to respect the PHP version used by Composer (instead of a system default).
- The scripts are set up to work equally well on Linux/Windows/Mac.
- The only two differences are:
    - The `mkdir` and file deletions won't automatically be done anymore.
        Generally speaking, the `mkdir` should only need to be run once anyway and the file deletes should not be necessary as the log files will just be overwritten by the tools, so I deemed this an acceptable trade-off.
    - The `colors` argument won't be set anymore.
        For most tools, this means, the tool will default to automatically determining whether the CLI used supports colourized output.
        As the determination of this in most tools has become pretty good, I, again, deemed this an acceptable trade-off.
This commit:
* Adds a GH Actions workflow for the code style CI check which was previously run on Travis.
* Removes that part of the `.travis.yml` configuration.
* Updates the `.gitattributes` file.
* Adds a separate badge for the CS workflow to the README.
This commit:
* Adds a GH Actions workflow for the PHP lint and unit test CI checks which were previously run on Travis.
* Removes the, now redundant, `.travis.yml` configuration.
* Updates the `.gitattributes` file.
* Updates the "Build Status" badge in the Readme to use the results from the GH `Test` Actions runs.
@grogy grogy merged commit 246c017 into php-parallel-lint:master May 9, 2021
@grogy
Copy link
Member

grogy commented May 9, 2021

Thank you, it looks very good 👍

@jrfnl jrfnl deleted the feature/15-switch-to-ghactions branch May 9, 2021 13:09
@jrfnl jrfnl modified the milestones: 1.x Next Release, 1.0.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Switch to using GH Actions
2 participants