Fixed: Count returns 1 on StdClass object

mrwogu · mrwogu · commit f837c8e1ce88 · 2018-02-03T17:09:18.000+01:00
diff --git a/src/Common/JsonSchema/JsonPatch.php b/src/Common/JsonSchema/JsonPatch.php
@@ -78,7 +78,8 @@ protected function handleObject(\stdClass $srcStruct, \stdClass $desStruct, stri
 
     protected function shouldPartiallyReplace(\stdClass $o1, \stdClass $o2): bool
     {
-        return count(array_diff_key((array) $o1, (array) $o2)) < count($o1);
+        // NOTE: count(stdClass) always returns 1
+        return count(array_diff_key((array) $o1, (array) $o2)) < 1;
     }
 
     protected function arrayDiff(array $a1, array $a2): array

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,8 @@ protected function handleObject(\stdClass $srcStruct, \stdClass $desStruct, stri`
`78`	`78`
`79`	`79`	`protected function shouldPartiallyReplace(\stdClass $o1, \stdClass $o2): bool`
`80`	`80`	`{`
`81`		`- return count(array_diff_key((array) $o1, (array) $o2)) < count($o1);`
	`81`	`+ // NOTE: count(stdClass) always returns 1`
	`82`	`+ return count(array_diff_key((array) $o1, (array) $o2)) < 1;`
`82`	`83`	`}`
`83`	`84`
`84`	`85`	`protected function arrayDiff(array $a1, array $a2): array`