Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add json extension to composer.json #81

Closed
wants to merge 1 commit into from
Closed

add json extension to composer.json #81

wants to merge 1 commit into from

Conversation

podolinek
Copy link

for example $curl->setHeader(CURLINFO_CONTENT_TYPE, 'application/x-www-form-urlencoded');

@podolinek
phpdoc: numeric constants to method $curl->setHeader(...)
3050e66 
for example $curl->setHeader(CURLINFO_CONTENT_TYPE, 'application/x-www-form-urlencoded');
@nadar nadar requested review from nadar and amouhzi July 29, 2022 09:09
nadar
nadar reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potential break installations without json, but indeed its correct that the json extension is needed to perform body encoding.

In order to prevent BC we could hold and release for 3.0

@nadar nadar added this to the 3.0 milestone Aug 29, 2022
@nadar nadar changed the title phpdoc: numeric constants to method $curl->setHeader(...) add json extension to composer.json Dec 3, 2022
nadar added a commit that referenced this pull request Oct 31, 2023
@nadar
make json extension required closes #81
7d5310f
@nadar
Copy link
Member

nadar commented Oct 31, 2023

See #105 - Thanks for mentioning!

@nadar nadar closed this Oct 31, 2023
@nadar nadar mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadar nadar nadar left review comments

@amouhzi amouhzi Awaiting requested review from amouhzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@podolinek @nadar