add json extension to composer.json #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example $curl->setHeader(CURLINFO_CONTENT_TYPE, 'application/x-www-form-urlencoded');
nadar
reviewed
Jul 29, 2022
Member
nadar
left a comment
nadar
left a comment
There was a problem hiding this comment.
This could potential break installations without json, but indeed its correct that the json extension is needed to perform body encoding.
In order to prevent BC we could hold and release for 3.0
nadar
changed the title
nadar
added a commit
that referenced
this pull request
Oct 31, 2023
Member
|
See #105 - Thanks for mentioning! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example $curl->setHeader(CURLINFO_CONTENT_TYPE, 'application/x-www-form-urlencoded');