Fix #522 Signed integer overflow #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sodabrew
reviewed
Feb 1, 2023
| @@ -86,7 +86,7 @@ static int php_memc_list_entry(void) { | |||
| /**************************************** | |||
| Payload value flags | |||
| ****************************************/ | |||
| #define MEMC_CREATE_MASK(start, n_bits) (((1 << n_bits) - 1) << start) | |||
| #define MEMC_CREATE_MASK(start, n_bits) (((1U << n_bits) - 1) << start) | |||
There was a problem hiding this comment.
I did a bit of reading, found a note that Coverity might interpret 1U as u_char rather than int: https://community.synopsys.com/s/article/False-positive-for-coverity-sees-1-and-1U-as-8-bit-type-variables
The fix would be to use 1UL to make it explicitly 32-bit (unsigned long)
There was a problem hiding this comment.
but 1UL is 64-bit
There was a problem hiding this comment.
Right, there's a part of my brain that I keep on a shelf for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.