Skip to content

Commit 9efe90f

Browse files
committed
Added error reporting to session code
1 parent de6b9b5 commit 9efe90f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

php_memcached_session.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,11 @@ PS_READ_FUNC(memcached)
331331
*vallen = payload_len;
332332
free(payload);
333333
return SUCCESS;
334-
} else {
334+
} else if (status == MEMCACHED_NOTFOUND) {
335+
/* this is okey, session may not be in memcached yet */
336+
return FAILURE;
337+
} else {
338+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc_sess->memc_sess));
335339
return FAILURE;
336340
}
337341
}
@@ -371,6 +375,7 @@ PS_WRITE_FUNC(memcached)
371375
if (status == MEMCACHED_SUCCESS) {
372376
return SUCCESS;
373377
} else {
378+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc_sess->memc_sess));
374379
write_try_attempts--;
375380
}
376381
} while (write_try_attempts > 0);

0 commit comments

Comments
 (0)