refactor: Clean up Albert API implementation

- Replace empty() with isset() checks in examples
- Remove unnecessary comments ending with 'OpenAI-compatible'
- Remove redundant doc comments
- Add HTTPS validation for Albert URL
- Make /v1 path handling more flexible
- Use data provider for URL tests
- Add test for HTTPS validation

Author: OskarStark

examples/albert/chat.php

@@ -10,30 +10,24 @@
 
 require_once dirname(__DIR__).'/../vendor/autoload.php';
 
-$albertApiKey = $_ENV['ALBERT_API_KEY'] ?? null;
-$albertApiUrl = $_ENV['ALBERT_API_URL'] ?? null;
-
-if (empty($albertApiKey)) {
+if (!isset($_ENV['ALBERT_API_KEY'])) {
     echo 'Please set the ALBERT_API_KEY environment variable.'.\PHP_EOL;
     exit(1);
 }
 
-if (empty($albertApiUrl)) {
+if (!isset($_ENV['ALBERT_API_URL'])) {
     echo 'Please set the ALBERT_API_URL environment variable (e.g., https://your-albert-instance.com).'.\PHP_EOL;
     exit(1);
 }
 
-// Create platform instance for Albert API
 $platform = PlatformFactory::create(
-    apiKey: $albertApiKey,
-    albertUrl: $albertApiUrl,
+    apiKey: $_ENV['ALBERT_API_KEY'],
+    albertUrl: $_ENV['ALBERT_API_URL'],
 );
 
 $model = new GPT('gpt-4o');
 $chain = new Chain($platform, $model);
 
-// Albert API supports RAG out of the box
-// You can pass document context as part of your messages
 $documentContext = <<<'CONTEXT'
     Document: AI Strategy of France
 

src/Platform/Bridge/Albert/EmbeddingsModelClient.php

@@ -11,9 +11,6 @@
 use Symfony\Contracts\HttpClient\ResponseInterface;
 use Webmozart\Assert\Assert;
 
-/**
- * Embeddings Model Client for Albert API (OpenAI-compatible).
- */
 final readonly class EmbeddingsModelClient implements ModelClientInterface
 {
     public function __construct(

src/Platform/Bridge/Albert/GPTModelClient.php

@@ -12,9 +12,6 @@
 use Symfony\Contracts\HttpClient\ResponseInterface;
 use Webmozart\Assert\Assert;
 
-/**
- * GPT Model Client for Albert API (OpenAI-compatible).
- */
 final readonly class GPTModelClient implements ModelClientInterface
 {
     private EventSourceHttpClient $httpClient;

src/Platform/Bridge/Albert/PlatformFactory.php

@@ -10,21 +10,26 @@
 use PhpLlm\LlmChain\Platform\Platform;
 use Symfony\Component\HttpClient\EventSourceHttpClient;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
+use Webmozart\Assert\Assert;
 
 final class PlatformFactory
 {
-    /**
-     * Creates a Platform instance for Albert API (OpenAI-compatible).
-     */
     public static function create(
         string $apiKey,
         string $albertUrl,
         ?HttpClientInterface $httpClient = null,
     ): Platform {
+        Assert::startsWith($albertUrl, 'https://', 'The Albert URL must start with "https://".');
+
         $httpClient = $httpClient instanceof EventSourceHttpClient ? $httpClient : new EventSourceHttpClient($httpClient);
 
-        // Configure base URL for Albert API
-        $baseUrl = rtrim($albertUrl, '/').'/v1/';
+        // The base URL should include the full path to the API endpoint
+        // Albert API expects the URL to end with /v1/
+        $baseUrl = rtrim($albertUrl, '/');
+        if (!str_ends_with($baseUrl, '/v1')) {
+            $baseUrl .= '/v1';
+        }
+        $baseUrl .= '/';
 
         // Create Albert-specific model clients with custom base URL
         $gptClient = new GPTModelClient($httpClient, $apiKey, $baseUrl);

tests/Platform/Bridge/Albert/PlatformFactoryTest.php

@@ -7,9 +7,11 @@
 use PhpLlm\LlmChain\Platform\Bridge\Albert\PlatformFactory;
 use PhpLlm\LlmChain\Platform\Platform;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
+use Webmozart\Assert\InvalidArgumentException;
 
 #[CoversClass(PlatformFactory::class)]
 #[Small]
@@ -24,13 +26,30 @@ public function createsPlatformWithCorrectBaseUrl(): void
     }
 
     #[Test]
-    public function trimsTrailingSlashFromUrl(): void
+    #[DataProvider('urlProvider')]
+    public function handlesUrlsCorrectly(string $url): void
     {
-        $platform1 = PlatformFactory::create('test-key', 'https://albert.example.com/');
-        $platform2 = PlatformFactory::create('test-key', 'https://albert.example.com');
+        $platform = PlatformFactory::create('test-key', $url);
 
-        // Both should create the same platform configuration
-        self::assertInstanceOf(Platform::class, $platform1);
-        self::assertInstanceOf(Platform::class, $platform2);
+        self::assertInstanceOf(Platform::class, $platform);
+    }
+
+    public static function urlProvider(): array
+    {
+        return [
+            'with trailing slash' => ['https://albert.example.com/'],
+            'without trailing slash' => ['https://albert.example.com'],
+            'with v1 path' => ['https://albert.example.com/v1'],
+            'with v1 path and trailing slash' => ['https://albert.example.com/v1/'],
+        ];
+    }
+
+    #[Test]
+    public function throwsExceptionForNonHttpsUrl(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The Albert URL must start with "https://".');
+
+        PlatformFactory::create('test-key', 'http://albert.example.com');
     }
 }