Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Commit e827b16

Browse files
OskarStarkclaude
andcommitted
test: remove redundant messageIdIsConsistent tests
The messageIdIsConsistent test was redundant because the existing messageHasUid test already verifies that $message->id and $message->getId() return the same instance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 283e2e0 commit e827b16

File tree

4 files changed

+0
-41
lines changed

4 files changed

+0
-41
lines changed

tests/Platform/Message/AssistantMessageTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,4 @@ public function messageIdImplementsRequiredInterfaces(): void
9191
self::assertInstanceOf(TimeBasedUidInterface::class, $message->getId());
9292
self::assertInstanceOf(UuidV7::class, $message->getId());
9393
}
94-
95-
#[Test]
96-
public function messageIdIsConsistent(): void
97-
{
98-
$message = new AssistantMessage('test');
99-
100-
// The same message instance should always return the same ID
101-
self::assertSame($message->getId(), $message->getId());
102-
self::assertSame($message->id, $message->getId());
103-
}
10494
}

tests/Platform/Message/SystemMessageTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,4 @@ public function messageIdImplementsRequiredInterfaces(): void
7171
self::assertInstanceOf(TimeBasedUidInterface::class, $message->getId());
7272
self::assertInstanceOf(UuidV7::class, $message->getId());
7373
}
74-
75-
#[Test]
76-
public function messageIdIsConsistent(): void
77-
{
78-
$message = new SystemMessage('test');
79-
80-
// The same message instance should always return the same ID
81-
self::assertSame($message->getId(), $message->getId());
82-
self::assertSame($message->id, $message->getId());
83-
}
8474
}

tests/Platform/Message/ToolCallMessageTest.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,4 @@ public function messageIdImplementsRequiredInterfaces(): void
7878
self::assertInstanceOf(TimeBasedUidInterface::class, $message->getId());
7979
self::assertInstanceOf(UuidV7::class, $message->getId());
8080
}
81-
82-
#[Test]
83-
public function messageIdIsConsistent(): void
84-
{
85-
$toolCall = new ToolCall('foo', 'bar');
86-
$message = new ToolCallMessage($toolCall, 'test');
87-
88-
// The same message instance should always return the same ID
89-
self::assertSame($message->getId(), $message->getId());
90-
self::assertSame($message->id, $message->getId());
91-
}
9281
}

tests/Platform/Message/UserMessageTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,4 @@ public function messageIdImplementsRequiredInterfaces(): void
121121
self::assertInstanceOf(TimeBasedUidInterface::class, $message->getId());
122122
self::assertInstanceOf(UuidV7::class, $message->getId());
123123
}
124-
125-
#[Test]
126-
public function messageIdIsConsistent(): void
127-
{
128-
$message = new UserMessage(new Text('test'));
129-
130-
// The same message instance should always return the same ID
131-
self::assertSame($message->getId(), $message->getId());
132-
self::assertSame($message->id, $message->getId());
133-
}
134124
}

0 commit comments

Comments
 (0)