Skip to content

Add httpsoft tests #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2023
Merged

Add httpsoft tests #73

merged 4 commits into from
May 25, 2023

Conversation

vjik
Copy link
Contributor

@vjik vjik commented May 23, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

@vjik vjik mentioned this pull request May 23, 2023
Merged
2 tasks
dbu
dbu reviewed May 24, 2023
View reviewed changes
@dbu
Copy link
Contributor

dbu commented May 24, 2023

thanks, cool! looking at the test output, there seems to be one issue with stream setup, otherwise httpsoft passes all tests 👍

dbu
dbu requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. i think you need to add a case for the httpsoft stream factory in src/BaseTest, like you did for UriFactory. then the remaining failures should be fixed.

@vjik
Copy link
Contributor Author

vjik commented May 25, 2023

thanks. i think you need to add a case for the httpsoft stream factory in src/BaseTest, like you did for UriFactory. then the remaining failures should be fixed.

Done.

dbu
dbu approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@dbu dbu merged commit 92ef823 into php-http:1.x May 25, 2023
@vjik vjik deleted the httpsoft branch May 25, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjik @dbu