Skip to content

Update to latest PSR-7 version #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2015

Conversation

weierophinney
Copy link
Contributor

Syncs all interface definitions with the latest revisions on php-fig/fig-standards.

This PR contains changes from the following as-yet unmerged pull-requests, and should therefore be merged after them:

- Syncs all interface definitions with the latest revisions on
  php-fig/fig-standards.
@weierophinney
Copy link
Contributor Author

Once merged, please tag 0.11.0, with the following:

Updates from Review-2

This tag contains all updates since entering the second review of PSR-7. These include:

- Clarifications to `RequestInterface::withUri()` specifying that changes MUST also update the `Host` header *unless* the `$preserverHost` flag is `true`.
- Removal of the various `getHeader*()` method overrides in `RequestInterface`, as they are irrelevant with the above change.
- Added verbiage to the `RequestInterface` class-level docblock indicating that constructors SHOULD attempt to set the `Host` header in order to ensure the message is valid on initialization.
- `RequestInterface::getHeaderLine()` MUST return a string (`null` was allowed previously, which leads to ambiguity of return value).
- `ResponseInterface::getReasonPhrase()` MUST return a string(`null` was allowed previously, which leads to ambiguity of return value).
- `ResponseInterface::withStatus()` now sets the default value of the `$reasonPhrase` parameter to an empty string (to correspond to the above change).
- `UploadedFileInterface::move()` was renamed to `moveTo()`, and the argument renamed to `$targetPath`; this clarifies intent for the method.
- `UriInterface::withPath()` has clarifications in the docblock to indicate the four possible path types (empty, root path, relative path, domain-relative — or absolute — path).

@weierophinney
Copy link
Contributor Author

Pinging @simensen and/or @pmjones — once the other PRs I've approved are merged, merge this one and tag, please.

pmjones pushed a commit that referenced this pull request May 4, 2015
@pmjones pmjones merged commit 809419e into php-fig:master May 4, 2015
@pmjones
Copy link
Contributor

pmjones commented May 4, 2015

Tagged.

@weierophinney weierophinney deleted the hotfix/sync-with-spec branch May 4, 2015 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants