Fix resolving DSN from dynamic environment variables #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a hack in the
DefaultTransportFactory
class namedresolveDSN
which allowed for basic environment variable resolving but not for dynamic resolving.E.g. this would work:
But this wouldn't:
With this fix this now works like it should.
I fixed it by moving the logic of creating connection factories, contexts and drivers to a compiler pass which allows for dynamic resolving of environment placeholders.
Because this was normally done in the extension itself, some tests had to be altered to run the compiler pass after registering the extension.