Skip to content

Commit

Permalink
fix(ci): updated version of phpunit and fixed workflow issues (#17)
Browse files Browse the repository at this point in the history
* perf: updated version of phpunit and fixed workflow issues

* chore: updated nodejs version in workflow
  • Loading branch information
Dobmod authored May 26, 2024
1 parent 1b5fed5 commit c8cb31b
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ jobs:
needs: [ test, upload-coverage ]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: '14.17'
node-version: 'lts/*'

- name: Run semantic-release
env:
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ composer.lock
*.iml

# coverage report
/build
/build
.phpunit*
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Yii-Permission

[![Build Status](https://travis-ci.org/php-casbin/yii-permission.svg?branch=master)](https://travis-ci.org/php-casbin/yii-permission)
[![Build Status](https://github.com/php-casbin/yii-permission/actions/workflows/build.yml/badge.svg?branch=master)](https://github.com/php-casbin/yii-permission/actions/workflows/build.yml)
[![Coverage Status](https://coveralls.io/repos/github/php-casbin/yii-permission/badge.svg)](https://coveralls.io/github/php-casbin/yii-permission)
[![Latest Stable Version](https://poser.pugx.org/casbin/yii-permission/v/stable)](https://packagist.org/packages/casbin/yii-permission)
[![Total Downloads](https://poser.pugx.org/casbin/yii-permission/downloads)](https://packagist.org/packages/casbin/yii-permission)
Expand Down
11 changes: 8 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"casbin/casbin": "~3.1"
},
"require-dev": {
"phpunit/phpunit": "~7.0",
"phpunit/phpunit": "~7.0|~8.0|~9.0|~10.5",
"php-coveralls/php-coveralls": "^2.1",
"yiisoft/yii2-app-basic": "~2.0.14"
},
Expand All @@ -42,5 +42,10 @@
"type": "composer",
"url": "https://asset-packagist.org"
}
]
}
],
"config": {
"allow-plugins": {
"yiisoft/yii2-composer": true
}
}
}
4 changes: 2 additions & 2 deletions tests/AdapterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ protected function refreshApplication()
/**
* This method is called before each test.
*/
protected function setUp()/* The :void return type declaration that should be here would cause a BC issue */
protected function setUp(): void/* The :void return type declaration that should be here would cause a BC issue */
{
if (!$this->app) {
$this->refreshApplication();
Expand All @@ -394,7 +394,7 @@ protected function setUp()/* The :void return type declaration that should be he
/**
* This method is called after each test.
*/
protected function tearDown()/* The :void return type declaration that should be here would cause a BC issue */
protected function tearDown(): void/* The :void return type declaration that should be here would cause a BC issue */
{
}

Expand Down

0 comments on commit c8cb31b

Please sign in to comment.