Adds middleware locator #4
Conversation
Based on the idea of the handlerLocator of Tactician this patch adds a middleware locator. To make this package more independend of the other packages of php-api-clients.
jaapio
force-pushed
the
feature/middleware-locator
branch
from
ec9f776 to
7f30d48
Compare
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Could you change this into <?php declare(strict_types=1); in this file and the other files
| @@ -17,6 +17,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "api-clients/test-utilities": "^1.0", | |||
| "container-interop/container-interop": "^1.1", | |||
There was a problem hiding this comment.
Shouldn't this be in require?
There was a problem hiding this comment.
Only required when using the ContainerLocator. Containers implementing this interface will always require it. So I think require-dev is sufficient.
There was a problem hiding this comment.
Yeah agree it is, but we might want to document it in the readme and add it to suggest notifying users when they install it in a project without one
There was a problem hiding this comment.
Where do you want me to push that docs? Will add a suggestion
There was a problem hiding this comment.
The readme would be fine (which could use more docs anyway tbh).
|
Added some basic docs should be enough to start with |
|
Awesome, thanks 👍 ! |
|
Cool! |
|
Just tagged |
Based on the idea of the handlerLocator of Tactician this patch adds
a middleware locator. To make this package more independend of the other packages
of php-api-clients.