Skip to content

Use Composer-style constrain #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Sep 21, 2020

kép

@g105b
Copy link
Member

g105b commented Sep 22, 2020

Hi @szepeviktor ,

Thank you for this. It took me a while to understand the difference, but I agree that using the Caret Version Range is beneficial for this Action, because of the lack of major stable release at phpstan. ^0.12.26 will upgrade to 0.13.0 but 0.12.* will not.

Thanks, I'll test this on a repository and merge your change in soon.

@g105b g105b merged commit 7948de0 into php-actions:master Sep 22, 2020
@szepeviktor szepeviktor deleted the patch-3 branch September 22, 2020 17:09
@szepeviktor
Copy link
Contributor Author

because of the lack of major stable release at phpstan. ^0.12.26 will upgrade to 0.13.0 but 0.12.* will not.

Please see https://jubianchi.github.io/semver-check/#/^0.12.0/0.13.1

@szepeviktor
Copy link
Contributor Author

@g105b
Copy link
Member

g105b commented Sep 22, 2020

Thanks for the info. Great to have you on board!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants