Skip to content

Commit 7dc6845

Browse files
committed
Fix TTY & docs.
1 parent 3a1ae6c commit 7dc6845

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

php-build.bash

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ dockerfile_unique="${dockerfile_unique,,}"
8888
repo_without_org=$(echo "$GITHUB_REPOSITORY" | sed "s/[^\/]*\///")
8989

9090
# This tag will be used to identify the built dockerfile. Once it is built,
91-
# it should not need to be built again, so after the first Github Actions run
92-
# the build should be very quick.
91+
# it should not need to be built again unless there is a PHP update, so after
92+
# the first Github Actions run the build should be very quick.
9393
# Note: The GITHUB_REPOSITORY is the repo where the action is running, nothing
9494
# to do with the php-actions organisation. This means that the image is pushed
9595
# onto a user's Github profile (currently not shared between other users).
@@ -111,8 +111,8 @@ then
111111
docker pull "$base_image" >> output.log 2>&1
112112

113113
# Check PHP versions of the latest PHP tag and our tag.
114-
base_image_php_version=$(docker run -it "$base_image" php -r "echo PHP_VERSION;")
115-
cached_image_php_version=$(docker run -it "$docker_tag" php -r "echo PHP_VERSION;")
114+
base_image_php_version=$(docker run -i "$base_image" php -r "echo PHP_VERSION;")
115+
cached_image_php_version=$(docker run -i "$docker_tag" php -r "echo PHP_VERSION;")
116116

117117
echo "Comparing $cached_image_php_version (cached) to $base_image_php_version (latest)." >> output.log 2>&1
118118

0 commit comments

Comments
 (0)