Access HttpServletRequest in Spring Controller that implements generated interface

[andrew-kratik]

Hi

Thanks for your great job!

Is there possibility to access HttpServletRequest object for current request in Spring Controller that implements generated interface?
using com.phoenixnap.oss.ramlapisync.generation.rules.Spring4ControllerInterfaceRule

The problem is that HttpServletRequest should be added to method signature in order to be injected, but there is no way to add this parameter to generated interfaces since it's not in RAML file. Also it's required only on some methods.

Thanks
Andrii

[stojsavljevic]

Thanks for getting in touch.

That's an interesting request and I think it can be very useful.

However, I don't think it should be related to raml itself.
Instead, we could introduce new configuration parameter (inside pom.xml) that will provide a list of method that will accept HttpServletRequest as last parameter.

What do you think?

[andrew-kratik]

Hi @stojsavljevic

Thanks for a quick reply
You read my thourghts:)

Config parameter inside pom.xml would be the best sollution since it's not related to RAML but Spring MVC specific. It should contain

1. type of paramter to be added to method signature (HttpServletRequest is one of options)
2. list of method that will accept additional parameter
3. optional name of this parameter

Thanks

[stojsavljevic]

I checked the code today and I find your proposal quite complex to implement.
Instead, I will do the same as for http headers object - there will be new configuration parameter injectHttpRequestParameter (false by default). If set to true all generated methods will be appended with HttpServletRequest parameter. The name will be httpRequest.