Fix JS error when socket is disconnect during patch redirect #4094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
added a commit
that referenced
this pull request
Jan 7, 2026
Collaborator
|
Thank you @ypconstante! Can you please try #4105? We already handle the redirect, but as you noted we still try to continue the patch while the LiveView is already unloaded. Now, instead of redirecting to the URL of the initial patch, we can just skip handling it. |
SteffenDE
added a commit
that referenced
this pull request
Jan 7, 2026
Contributor
Author
|
@SteffenDE tested #4105 and it solves the issue! |
SteffenDE
added a commit
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the project I'm working on we're getting some
Cannot read properties of null (reading 'id')errors in the historyRedirect function.This error happens when we disconnect and redirect the user in
handle_params. In my tests, whenpushHistoryPatchis called in this situation the socket was still connected, but it was disconnected whenpushLinkPatchcallback was called.To fix the issue this PR updates
pushHistoryPatchto do the connected check again in thepushLinkPatchcallback.