Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLM calculations (python) #7

Open
5 of 8 tasks
phockett opened this issue Sep 13, 2019 · 11 comments
Open
5 of 8 tasks

BLM calculations (python) #7

phockett opened this issue Sep 13, 2019 · 11 comments

Comments

@phockett
Copy link
Owner

phockett commented Sep 13, 2019

Things to do:

  • Normalisation
  • Vectorization/parallelization
  • Verification
  • Saving of Xarrays
  • Tensor formalism
  • Matrix formalism
  • AF-BLM calculations
  • ADM (and other, esp. external values) normalisation options/routines.
@phockett phockett added the todo label Sep 13, 2019
@phockett phockett changed the title BLM calculations BLM calculations (python) Sep 13, 2019
@phockett
Copy link
Owner Author

phockett commented Sep 13, 2019

Testing code (local only) D:\code\ePSproc\python_dev\ePSproc_MFBLM_dev_tests_050919.py

Notebook demo (ongoing): ePSproc_BLM_calc_demo_Sept2019.ipynb

@phockett
Copy link
Owner Author

Basic code now working & verified. Pretty slow.

@phockett
Copy link
Owner Author

Should be able to get a good speed-up on repetitive function calls with caching: https://docs.python.org/dev/library/functools.html#functools.lru_cache.

See also numba development branch for other methods.

@phockett
Copy link
Owner Author

Normalisation by SF and B00 > X-section now in MF-BLM calcs (dev version).

@phockett
Copy link
Owner Author

Initial version of AF-BLM code added. Running, not verified (almost certainly wrong).

@phockett
Copy link
Owner Author

Updated AF-BLM code for Xarray ADMs. Sort-of working. Careful testing still required.

@phockett
Copy link
Owner Author

phockett commented Apr 10, 2020

Tensor formalism now basically working. Debugged for N2 (z,x,y) case, and verified against existing loop code. A few issues left to clear up, mainly consistency and tidy-up, plus some new capabilities.

TODO:

  • Check for source of small differences (but >threshold) between old and new calcs. Look to be Eke dependent, so likely SF and/or/with thresholding method.
  • Test for other pol geoms and sym mixing.
  • Plotting.

@phockett
Copy link
Owner Author

phockett commented Jul 6, 2020

Tensor formalism also now used for LF case, for direct comparison with ePS GetCro outputs, see https://epsproc.readthedocs.io/en/dev/methods/LF_AF_verification_tests_260620_tidy.html.

Still TODO:

  • Verify for AF case.
  • Degeneracy factors for general/AF case.
  • General tidy & rewrite dev code.

@phockett
Copy link
Owner Author

Revisiting AF case, looks like 'it' degeneracy needs some work - implicit frame rotation here? For N2 pi-g test case, get -ve X-sections with current calculation, which implies phase issues and/or renorm issue.

@phockett
Copy link
Owner Author

ALSO: seem to have an inconsistency with (x,y) pol geometries here - should check source code & fix. Likely due to mix-up in frame defns., i.e. need to define (x,y) in LF not MF?

@phockett
Copy link
Owner Author

See #26 for ongoing issues for geometric/tensor versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant