Fix filename uniqueness when using TempfileTask#1917
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
=========================================
Coverage 53.30% 53.31%
Complexity 9797 9797
=========================================
Files 495 495
Lines 24639 24639
=========================================
+ Hits 13135 13136 +1
+ Misses 11504 11503 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…mporary filenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that filenames generate by TempfileTask are not unique when they are called multiple times at high frequency.
For example, given the following target:
This is going to be the output:
As you can see all filenames are identical, the reason is that current implementation uses
time()function as seed for filename generation, which only has second-level precision.I fix this issue replacing
time()withmicrotime().