Phing 3.* and PHPUnit 12.* impossible to use together

[zablose]

Phing 3.0.1 impossible to use in a project with PHPUnit 12.1.2.
Getting these errors on composer update:

Problem 1
    - Root composer.json requires phing/phing ^3.0.1 -> satisfiable by phing/phing[3.0.1].
    - Root composer.json requires phpunit/phpunit ^12.1.2 -> satisfiable by phpunit/phpunit[12.1.2].
    - phing/phing 3.0.1 requires sebastian/version ^3.0|^4.0|^5.0 -> satisfiable by sebastian/version[3.0.0, 3.0.1, 3.0.2, 4.0.0, 4.0.1, 5.0.0, 5.0.1, 5.0.2].
    - phpunit/phpunit 12.1.2 requires sebastian/version ^6.0.0 -> satisfiable by sebastian/version[6.0.0].
    - sebastian/version 3.0.0 requires php ^7.3 -> your php version (8.4.5) does not satisfy that requirement.
    - You can only install one version of a package, so only one of these can be installed: sebastian/version[3.0.0, 3.0.1, 3.0.2, 4.0.0, 4.0.1, 5.0.0, 5.0.1, 5.0.2, 6.0.0].

Oddly enough, when I use older version of Phing 2.17.4 - all is good.

Probably, sebastian/version is missing ^6.0 in composer.json file:

"require": {
        ...
        "sebastian/version": "^3.0|^4.0|^5.0",
        ...
    }

[williamdes]

For phpunit 10+ I started with this fixes

diff --git a/src/Phing/Task/Ext/PhpUnit/PHPUnitTask.php b/src/Phing/Task/Ext/PhpUnit/PHPUnitTask.php
index 00edaee3..8bd63249 100644
--- a/src/Phing/Task/Ext/PhpUnit/PHPUnitTask.php
+++ b/src/Phing/Task/Ext/PhpUnit/PHPUnitTask.php
@@ -27,6 +27,7 @@ use Phing\Io\LogWriter;
 use Phing\Io\File;
 use Phing\Task;
 use PHPUnit\Framework\TestSuite;
+use PHPUnit\Framework\TestCase;
 use PHPUnit\TextUI\XmlConfiguration\Loader;
 use ReflectionException;
 use ReflectionClass;
@@ -459,7 +460,7 @@ class PHPUnitTask extends Task
         }
 
         $this->loadPHPUnit();
-        $suite = new \PHPUnit\Framework\TestSuite('AllTests');
+        $suite = \PHPUnit\Framework\TestSuite::empty('AllTests');
         $autoloadSave = spl_autoload_functions();
 
         if ($this->bootstrap) {
@@ -696,7 +697,9 @@ class PHPUnitTask extends Task
     protected function appendBatchTestToTestSuite(BatchTest $batchTest, $suite)
     {
         foreach ($batchTest->elements() as $element) {
-            $testClass = new $element();
+            // First argument is the test name
+            $testClass = new $element($element);
+
             if (!($testClass instanceof TestSuite)) {
                 $testClass = new ReflectionClass($element);
             }

But could not continue as there is too much more in the test runner to be done

[mrook]

The next release will allow sebastian/version ^6.0.

Whether or not we should continue with the PHPUnit task the way it is (directly integrating with internal PHPUnit code) is up for debate. The PHPUnit internals change significantly from version to version which ends up breaking our integration. Mind you - that's a consequence of our choice, not PHPUnit's.

[mrook]

Addressed in 01e9524

[williamdes]

For some reason we still require dev phpunit 9, making the tests virtually run fine.

phing/composer.json

Line 108 in 1727758

"phpunit/phpunit": "^9.6.21",

But they can not pass with more recent phpunit versions.

Maybe @mrook this issue should be re-open ?

[mrook]

Hi @williamdes , I'll open a new issue to track the support for PHPUnit 10+ in the PHPUnit Task. That's going to involve some (significant) work, because we integrate tightly in PHPUnit's core, which ends up changing significantly between major releases.