Error with MkdirTask

[jawira]

Describe the bug

MkdirTask displays errors when creating nested directories in PHP 8.

Steps To Reproduce

You can reproduce the problem with the following buildfile:

<?xml version="1.0" encoding="UTF-8"?>
<project name="demo" default="create-dirs">

    <target name="create-dirs">
        <delete dir="foo"/>
        <mkdir dir="foo/bar/baz"/>
    </target>

</project>

Execute the target using PHP 8:

$ /usr/bin/php8.0 /usr/local/bin/phing create-dirs
Buildfile: /home/jawira/PhpstormProjects/deleteme/build.xml

demo > create-dirs:

   [delete] Deleting directory /home/jawira/PhpstormProjects/deleteme/foo
[PHP Error] mkdir(): No such file or directory [line 398 of phar:///usr/local/bin/phing/src/Phing/Io/FileSystem.php]
[PHP Error] mkdir(): No such file or directory [line 398 of phar:///usr/local/bin/phing/src/Phing/Io/FileSystem.php]
    [mkdir] Created dir: /home/jawira/PhpstormProjects/deleteme/foo/bar/baz

BUILD FINISHED

Total time: 0.1032 seconds

Expected behavior

Execute create-dirs with PHP 7.4 in order to see the expected behaviour:

$ /usr/bin/php7.4 /usr/local/bin/phing create-dirs
Buildfile: /home/jawira/PhpstormProjects/deleteme/build.xml

demo > create-dirs:

   [delete] Deleting directory /home/jawira/PhpstormProjects/deleteme/foo
    [mkdir] Created dir: /home/jawira/PhpstormProjects/deleteme/foo/bar/baz

BUILD FINISHED

Total time: 0.1020 seconds

As you can see in the output, there's no [PHP Error].

Additional context

The error occurs in the line:

phing/src/Phing/Io/FileSystem.php

Line 398 in d98239f

$return = @mkdir($f->getAbsolutePath());

The problem is the @ error suppression operator. In PHP 8 this operator has been modified, some errors are not silenced anymore.

Source: https://php.watch/versions/8.0/fatal-error-suppression

[siad007]

@jawira solved 🙇🏼

[MaximilianKresse]

The error still exists in the current main branch.

It looks like the problem is in your error handler. The error handler doesn't handle the silent operator @ correctly: https://github.com/phingofficial/phing/blob/main/src/Phing/Phing.php#L1091

With PHP 8.0 there were a change to the behavior.
Impact on Error Handlers is important for you.

TLDR: Change the (error_reporting() > 0) with something like:

if (!(\error_reporting() & $level)) {
    return true; // Silenced
}

[artur-stepien]

This stil exists in 3.0.1 ... How come it is closed

[mrook]

Can you explain your issue @artur-stepien ?

[artur-stepien]

Using MkdirTask on a path with non-existing parents (eg. /build/packages/extension where only /build directory exists) results in mkdir(): No such file or directory error. To suppress the error you have to create directories one by one what is a waste of space and time.

Adding a $recursive parameter to mkdir() in \Phing\Io\FileSystem::createDirectory::createDirectory() would require less XML in a build file in such case.

I'm using Phing 3.0.1 with PHP 8.3.1 on a Windows 10 workstation.

[mrook]

Hi @artur-stepien, taking another look at the build file in the top of this issue. The errors can be ignored, the sub directories are actually created. I'll take another look at fixing / clearing out the errors.

[artur-stepien]

Yeah, but not everyone likes the warnings that are false-positive. Just adding $recursive to the mkdir() would do the job. Directories created so no reason to suppress the errors in this function.