chore: Upgrade dependencies (#57)

* upgrade easy dependencies

* ⬆️ probot 7.5

* ⬆️ probot 9.0

* ⬆️ probot 9.2.20

* 👕 lint

Author: philschatz

package.json

@@ -6,7 +6,8 @@
   "scripts": {
     "start": "probot run ./src/index.js",
     "lint": "standard --fix",
-    "test": "jest && standard",
+    "test": "jest",
+    "posttest": "standard",
     "test:fix": "jest --updateSnapshot && standard --fix"
   },
   "repository": {
@@ -27,13 +28,13 @@
     "collectCoverage": true
   },
   "dependencies": {
-    "commonmark": "^0.28.1",
-    "probot": "^6.1.0"
+    "commonmark": "^0.29.0",
+    "probot": "^9.2.20"
   },
   "devDependencies": {
     "jest": "^24.8.0",
     "nock": "^10.0.6",
-    "smee-client": "^1.0.1",
-    "standard": "^11.0.1"
+    "smee-client": "^1.1.0",
+    "standard": "^13.1.0"
   }
 }

src/commands.js

@@ -128,7 +128,8 @@ module.exports = [
     ruleMatcher: async function (logger, context, ruleArgs) {
       // See https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent
       // Check if there are any Pending or Rejected reviews and ensure there is at least one Accepted one
-      const {data: reviews} = await context.github.pullRequests.getReviews(context.issue())
+      const issue = context.issue()
+      const { data: reviews } = await context.github.pullRequests.listReviews({ owner: issue.owner, repo: issue.repo, pull_number: issue.number })
       // Check that there is at least one Accepted
       const hasAccepted = reviews.filter((review) => review.state === 'APPROVED').length >= 1
       const hasRejections = reviews.filter((review) => review.state === 'REQUEST_CHANGES').length >= 1

src/extract-rules.js

@@ -20,7 +20,7 @@ function parseMarkdown (card) {
   const parsedRules = []
   let walkEvent
   while ((walkEvent = walker.next())) {
-    const {node} = walkEvent
+    const { node } = walkEvent
     // Each item should be simple text that contains the rule, followed by a space,
     // followed by any arguments (sometimes wrapped in spaces)
     if (walkEvent.entering && node.type === 'code') {
@@ -38,7 +38,7 @@ function parseMarkdown (card) {
         if (args.length === 0 && node.next && node.next.literal) {
           args = node.next.literal.trim().split(' ').map((arg) => arg.trim())
         }
-        parsedRules.push({ruleName: node.literal, ruleArgs: args})
+        parsedRules.push({ ruleName: node.literal, ruleArgs: args })
       }
     }
   }
@@ -54,15 +54,15 @@ module.exports = function extractAutomationRules (projects) {
   projects.forEach((project) => {
     project.columns.nodes.forEach((column) => {
       column.firstCards.nodes.forEach((card) => {
-        allCards.set(card.id, {card, column})
+        allCards.set(card.id, { card, column })
       })
       column.lastCards.nodes.forEach((card) => {
-        allCards.set(card.id, {card, column})
+        allCards.set(card.id, { card, column })
       })
     })
   })
 
-  allCards.forEach(({card, column}) => {
+  allCards.forEach(({ card, column }) => {
     const rules = parseMarkdown(card)
     rules.forEach((r) => {
       automationRules.push({

src/index.js

@@ -12,10 +12,10 @@ async function sleep (ms) {
 // Often, there is a delay between the webhook firing and GaphQL updating
 async function retryQuery (context, query, args) {
   try {
-    return await context.github.query(query, args)
+    return await context.github.graphql(query, args)
   } catch (err) {
     await sleep(1000)
-    return context.github.query(query, args)
+    return context.github.graphql(query, args)
   }
 }
 
@@ -49,14 +49,14 @@ const PROJECT_FRAGMENT = `
 `
 
 module.exports = (robot) => {
-  const logger = robot.log.child({name: 'project-bot'})
+  const logger = robot.log.child({ name: 'project-bot' })
   // Increase the maxListenerCount by the number of automationCommands
   // because we register a bunch of listeners
   robot.events.setMaxListeners(robot.events.getMaxListeners() + automationCommands.length)
   logger.info(`Starting up`)
 
   // Register all of the automation commands
-  automationCommands.forEach(({createsACard, webhookName, ruleName, ruleMatcher}) => {
+  automationCommands.forEach(({ createsACard, webhookName, ruleName, ruleMatcher }) => {
     logger.trace(`Attaching listener for ${webhookName}`)
     robot.on(webhookName, async function (context) {
       const issueUrl = context.payload.issue ? context.payload.issue.html_url : context.payload.pull_request.html_url.replace('/pull/', '/issues/')
@@ -92,8 +92,8 @@ module.exports = (robot) => {
               }
             }
           }
-        `, {issueUrl: issueUrl})
-        const {resource} = graphResult
+        `, { issueUrl: issueUrl })
+        const { resource } = graphResult
 
         let allProjects = []
         if (resource.repository.owner.projects) {
@@ -105,25 +105,25 @@ module.exports = (robot) => {
         }
 
         // Loop through all of the Automation Cards and see if any match
-        const automationRules = extractAutomationRules(allProjects).filter(({ruleName: rn}) => rn === ruleName)
+        const automationRules = extractAutomationRules(allProjects).filter(({ ruleName: rn }) => rn === ruleName)
 
-        for (const {column, ruleArgs} of automationRules) {
+        for (const { column, ruleArgs } of automationRules) {
           if (await ruleMatcher(logger, context, ruleArgs)) {
             logger.info(`Creating Card for "${issueUrl}" to column ${column.id} because of "${ruleName}" and value: "${ruleArgs}"`)
-            await context.github.query(`
+            await context.github.graphql(`
               mutation createCard($contentId: ID!, $columnId: ID!) {
                 addProjectCard(input: {contentId: $contentId, projectColumnId: $columnId}) {
                   clientMutationId
                 }
               }
-            `, {contentId: resource.id, columnId: column.id})
+            `, { contentId: resource.id, columnId: column.id })
           }
         }
       } else {
         // Check if we need to move the Issue (or Pull request)
         const graphResult = await retryQuery(context, `
-          query getCardAndColumnAutomationCards($url: URI!) {
-            resource(url: $url) {
+          query getCardAndColumnAutomationCards($issueUrl: URI!) {
+            resource(url: $issueUrl) {
               ... on Issue {
                 projectCards(first: 10) {
                   nodes {
@@ -141,28 +141,28 @@ module.exports = (robot) => {
               }
             }
           }
-        `, {url: issueUrl})
+        `, { issueUrl: issueUrl })
         logger.debug(graphResult, 'Retrieved results')
-        const {resource} = graphResult
+        const { resource } = graphResult
         // sometimes there are no projectCards
         if (!resource.projectCards) {
           logger.error(issueUrl, resource, 'Not even an array for project cards. Odd')
         }
         const cardsForIssue = resource.projectCards ? resource.projectCards.nodes : []
 
         for (const issueCard of cardsForIssue) {
-          const automationRules = extractAutomationRules([issueCard.project]).filter(({ruleName: rn}) => rn === ruleName)
+          const automationRules = extractAutomationRules([issueCard.project]).filter(({ ruleName: rn }) => rn === ruleName)
 
-          for (const {column, ruleArgs} of automationRules) {
+          for (const { column, ruleArgs } of automationRules) {
             if (await ruleMatcher(logger, context, ruleArgs)) {
               logger.info(`Moving Card ${issueCard.id} for "${issueUrl}" to column ${column.id} because of "${ruleName}" and value: "${ruleArgs}"`)
-              await context.github.query(`
+              await context.github.graphql(`
                 mutation moveCard($cardId: ID!, $columnId: ID!) {
                   moveProjectCard(input: {cardId: $cardId, columnId: $columnId}) {
                     clientMutationId
                   }
                 }
-              `, {cardId: issueCard.id, columnId: column.id})
+              `, { cardId: issueCard.id, columnId: column.id })
             }
           }
         }