Flex basis alias support

[lievenjanssen]

Some additional improvements/questions:

• Currently we both support data-fx-flex-grow and data-fx-flex="grow" for attributes. Should we deprecate data-fx-flex-grow?
• Can we replace

  css-fx-layout/src/lib/flex-classes.scss

  Line 13 in c0b3b02

  *:has(>.fx-flex,>.fx-flex-grow):not([class*="fx-layout-"]) {

  by *:has(>[class^="fx-flex"]):not([class*="fx-layout-"]) and remove these lines:

  css-fx-layout/src/lib/flex-classes.scss

  Lines 30 to 32 in c0b3b02

  	*:has(>.fx-flex--#{$name},>.fx-flex-grow--#{$name}):not([class*="fx-layout-"]) {
  	@include flex-row-properties;
  	}

• Is there a reason why we don't automatically add flex to the parent container of flex-attributes-for-media-sizes?

  css-fx-layout/src/lib/flex-attributes.scss

  Lines 18 to 19 in c0b3b02

  	// these do not automatically add flex to their parent container
  	@mixin flex-attributes-for-media-sizes {

What do you think?

[philmtd]

Hey, thank you so much for this PR!

Currently we both support data-fx-flex-grow and data-fx-flex="grow" for attributes. Should we deprecate data-fx-flex-grow?

Yes, I think we should deprecate it.

Can we replace [...]

I think we can. I'm not sure why I did it the way it is implemented now but currently I don't see why using the shortcut you suggested should not work. Probably I did not take enough time to figure out the best solution 🙃

Is there a reason why we don't automatically add flex to the parent container of flex-attributes-for-media-sizes?

I think I assumed that, when you use flex with media sizes you will definitely also use flex without media sizes, which would already add the properties to the parent. But I guess that would not work in projects where there are no default styles applied and only media sizes used. What do you think about this? Should we add it? I'm not sure how important that would be but I'm open to adding it if you think it may be useful.

[lievenjanssen]

There's actually an issue with the auto apply row layout shortcut. It needs to be more specific since you only want to apply the flex-row-properties for the correct media query. I'll probably leave the current implementation for now.

I think we should at least be consistent if we add it automatically to the flex class media query selectors to also add it to the flex attribute media query selectors. I think there are use cases where you would only apply flex on a certain screen size while not having a general flex. Ok to fix it like that?

[philmtd]

Ok to fix it like that?

Absolutely, that makes sense!

[philmtd]

This looks good to me now. Is there anything open you want to change here? If not I'd merge that.

[lievenjanssen]

This looks good to me now. Is there anything open you want to change here? If not I'd merge that.

This can be merged. I didn't update the documentation yet though. Is that something you could do?

[philmtd]

Sure, I can take care of the documentation. I was thinking of moving the docs from the Wiki over to the repo anyway so the docs are versioned together with the code.