Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Amazon linux by Ubuntu #4178

Open
npalm opened this issue Oct 10, 2024 · 1 comment
Open

Replace Amazon linux by Ubuntu #4178

npalm opened this issue Oct 10, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@npalm
Copy link
Member

npalm commented Oct 10, 2024

Description

Currently we are shipping by default in the module scripts tuned for Amazon Linux and with some extra configuration Ubuntu can be used. But since GitHub is standard relying on Ubuntu several actions are not working on Amazon Linux. Or sometime updates of actions.are not fully supported out of the box.

By changing de standard configured linux version to Ubuntu we keep the module closer to the GitHub standard hosted runners. With extra configuration you can still adjust the Linux version

Once implemented this will trigger a major release.

Implementations directions

  • Adjust scripts based on Ubuntu example.
  • Update the launch templates default to Ubuntu
  • Replace ubuntu example by an Amazon Linux one
  • Update multi-runner examples
  • Docs update

Other

Help, suggestions and feedback is welcome.

@npalm npalm added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2024
@bdellegrazie
Copy link

Hi, I've updated the Ubuntu example in mutli-runner to work correctly on my PR.
That should give you a starting point.

I'd also suggest making the choice between rootless and rootful docker a configuration option, especially for ephemeral nodes (I realise this is a security risk so default to rootless).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants