Use the tab's URL to check if the Vimium is enabled

Previously we were accessing the top frame's URL, which fails due to cross-origin restrictions if
the frames are from different origins.

Author: philc

background_scripts/main.js

@@ -560,8 +560,9 @@ const sendRequestHandlers = {
   },
 
   async initializeFrame(request, sender) {
-    const tabId = sender.tab.id;
-    const enabledState = Exclusions.isEnabledForUrl(request.topFrameUrl);
+    // Check whether the extension is enabled for the top frame's URL, rather than the URL of the
+    // specific frame that sent this request.
+    const enabledState = Exclusions.isEnabledForUrl(sender.tab.url);
 
     const isTopFrame = sender.frameId == 0;
     if (isTopFrame) {
@@ -588,7 +589,7 @@ const sendRequestHandlers = {
           "32": "../icons/action_disabled_32.png",
         },
       };
-      chrome.action.setIcon({ path: iconSet[whichIcon], tabId: tabId });
+      chrome.action.setIcon({ path: iconSet[whichIcon], tabId: sender.tab.id });
     }
 
     const response = Object.assign({

content_scripts/vimium_frontend.js

@@ -409,10 +409,7 @@ globalThis.lastFocusedInput = (function () {
 
 // Checks if Vimium should be enabled or not based on the top frame's URL.
 const checkIfEnabledForUrl = async () => {
-  const response = await chrome.runtime.sendMessage({
-    handler: "initializeFrame",
-    topFrameUrl: window.top.location.toString(),
-  });
+  const response = await chrome.runtime.sendMessage({ handler: "initializeFrame" });
 
   isEnabledForUrl = response.isEnabledForUrl;