Add an option to blur flash embeds as part of exiting insert mode.

Disabled by default.

Author: mrmr1993

background_scripts/settings.coffee

@@ -66,6 +66,7 @@ root.Settings = Settings =
     linkHintNumbers: "0123456789"
     filterLinkHints: false
     hideHud: false
+    enableBlurEmbeds: false
     userDefinedLinkHintCss:
       """
       div > .vimiumHintMarker {

content_scripts/vimium_frontend.coffee

@@ -49,7 +49,7 @@ settings =
   loadedValues: 0
   valuesToLoad: ["scrollStepSize", "linkHintCharacters", "linkHintNumbers", "filterLinkHints", "hideHud",
     "previousPatterns", "nextPatterns", "findModeRawQuery", "regexFindMode", "userDefinedLinkHintCss",
-    "helpDialog_showAdvancedCommands"]
+    "helpDialog_showAdvancedCommands", "enableBlurEmbeds"]
   isLoaded: false
   eventListeners: {}
 
@@ -398,6 +398,8 @@ onKeydown = (event) ->
         keyChar = "<" + keyChar + ">"
 
   if (isInsertMode() && KeyboardUtils.isEscape(event))
+    # Blurring out of embeds could be dangerous, do nothing unless the user explicitly enables it.
+    return if isEmbed(event.srcElement) and not settings.get "enableBlurEmbeds"
     if isEditable(event.srcElement) or isEmbed(event.srcElement)
       # Remove focus so the user can't just get himself back into insert mode by typing in the same input
       # box.

pages/options.coffee

@@ -181,6 +181,7 @@ document.addEventListener "DOMContentLoaded", ->
     linkHintNumbers: NonEmptyTextOption
     nextPatterns: NonEmptyTextOption
     previousPatterns: NonEmptyTextOption
+    enableBlurEmbeds: CheckBoxOption
     regexFindMode: CheckBoxOption
     scrollStepSize: NumberOption
     searchEngines: TextOption

pages/options.html

@@ -327,6 +327,20 @@
               </label>
             </td>
           </tr>
+          <tr>
+            <td class="caption"></td>
+            <td verticalAlign="top" class="booleanOption">
+              <div class="help">
+                <div class="example">
+                  This is an experimental option, and could break embeds (eg. some flash games) that expect to handle the escape key.
+                </div>
+              </div>
+              <label>
+                <input id="enableBlurEmbeds" type="checkbox"/>
+                Enable blurring embed elements to exit insert mode.
+              </label>
+            </td>
+          </tr>
           <tr>
             <td class="caption"></td>
             <td verticalAlign="top" class="booleanOption">