show value that caused a test to fail

[guberathome]

When debugging a failed test (from the make file), I was interested in the incorrect value which was returned instead of the expected one
(since that would give me an error code).

A quick hack got me the information I needed but I suspect there should be a better way to do this.
Here are my changes to fth/t_tools.fth:

: }T    \ ( ... -- ) Compare stack (expected) contents with saved
        \ (actual) contents.
    DEPTH
    actual-depth @ =
    IF  \ if depths match
        1 test-passed +!  \ assume will pass
        DEPTH 0
        ?DO             \ for each stack item
            actual-results I CELLS + @ \ compare actual with expected
\ original code:
\           <>
\           IF
\ start-hack1
            2dup
            =
            if
                2drop
            else
                ." got=" . ." , expected=" . 
\ stop-hack1
                -1 test-passed +!
                1 test-failed +!
                S" INCORRECT RESULT: " error
                LEAVE
            THEN

Essentially I did not find an obvious way to concatenate strings.
Any suggestions?

[guberathome]

Here's a slightly less hacky version:

• int>str and concat might need some polish and relocation to the correct file, e.g. strings.fth

: int>str s>d swap over dabs <# #s rot sign #> ;  \ adapted from GForth manual section "Formatted numeric output", source: https://gforth.org/manual/Formatted-numeric-output.html 
: concat { addr1 len1 addr2 len2 | addr3 len3 -- addr3 len3 }
  \ concatenates string at addr2 to string at addr1
  len1 len2 + dup -> len3
  chars allocate abort" panic: can not allocate result buffer in concat" -> addr3
  addr1 addr3        len1 cmove
  addr2 addr3 len1 + len2 cmove
  addr3 len3
  ;
: concat+free { addr1 len1 addr2 len2  -- addr3 len3 }
  addr1 len1 addr2 len2 concat addr1 free abort" panic: can not free temporary buffer-1 in concat+free" ;
: }T    \ ( ... -- ) Compare stack (expected) contents with saved
        \ (actual) contents.
    DEPTH
    actual-depth @ =
    IF  \ if depths match
        1 test-passed +!  \ assume will pass
        DEPTH 0
        ?DO             \ for each stack item
            actual-results I CELLS + @ \ compare actual with expected
            2dup
            =
            if
                2drop
            else
                >R >R
                -1 test-passed +!
                1 test-failed +!                
                s" INCORRECT RESULT (expected=" R> int>str concat
                s" , got="         concat+free  R> int>str concat+free 
                s" ): "            concat+free
                error
                LEAVE
            THEN
        LOOP
    ELSE                \ depth mismatch
        1 test-failed +!
        S" WRONG NUMBER OF RESULTS: " error
    THEN
;

[guberathome]

addressed a #185 => closed