Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_placeCritical() bad logic was executed #287

Open
008v opened this issue Apr 16, 2019 · 0 comments
Open

_placeCritical() bad logic was executed #287

008v opened this issue Apr 16, 2019 · 0 comments

Comments

@008v
Copy link

008v commented Apr 16, 2019

An incorrect operation was performed in the _placeCritical() method.

Specifically,

  _onScrollEnd = (event) => {
    const offset = { ...event.nativeEvent.contentOffset };
    const page = this._calculateCurrentPage(offset.x);
    this._placeCritical(page);     // <--  scroll to some page without animation when onScrollEnd()
    this._setCurrentPage(page);
    this._setUpTimer();
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant