Move pusherpool startup into _base.setup (matrix-org#7104)

This should be safe to do on all workers/masters because it is guarded by
a config option which will ensure it is only actually done on the worker
assigned as a pusher.

Author: richvdh

changelog.d/7104.misc

@@ -0,0 +1 @@
+Merge worker apps together.

synapse/app/_base.py

@@ -276,6 +276,7 @@ def handle_sighup(*args, **kwargs):
         # It is now safe to start your Synapse.
         hs.start_listening(listeners)
         hs.get_datastore().db.start_profiling()
+        hs.get_pusherpool().start()
 
         setup_sentry(hs)
         setup_sdnotify(hs)

synapse/app/homeserver.py

@@ -408,7 +408,6 @@ def start():
 
             _base.start(hs, config.listeners)
 
-            hs.get_pusherpool().start()
             hs.get_datastore().db.updates.start_doing_background_updates()
         except Exception:
             # Print the exception and bail out.