Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add Excel File support out of the box. #1488

Open
vinaayakha opened this issue Nov 26, 2024 · 6 comments
Open

[Feature Request]: Add Excel File support out of the box. #1488

vinaayakha opened this issue Nov 26, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vinaayakha
Copy link

CSV is cool, but as I process a lot of Excel, I created a custom model but thought it would be great to have it out of the box in the phi data framework to dump a data frame from Excel.

Should I raise a PR for review?

@manthanguptaa
Copy link
Contributor

Hey @vinaayakha, please go ahead. This would be a wonderful addition to Phidata!

@manthanguptaa manthanguptaa added enhancement New feature or request help wanted Extra attention is needed labels Nov 26, 2024
@vinaayakha
Copy link
Author

Hey @manthanguptaa, Thanks for assigning it to me. I will be able to complete it in 8 working days, and I will start at in Dec 01 2024.

@manthanguptaa
Copy link
Contributor

Hey @vinaayakha, how is the PR coming along?

@vinaayakha
Copy link
Author

Hey @vinaayakha, how is the PR coming along?

Hi @manthanguptaa, I've added the necessary changes to the tool, I still want to test it some, Due to my work, I haven't been able to do it. I hope to raise a PR this weekend for this change request.

Thanks.

@vinaayakha
Copy link
Author

Hi @manthanguptaa, Can i add the library unstructured==0.16.11? It has a lot of working tools that is required for excel parsing.

@manthanguptaa
Copy link
Contributor

manthanguptaa commented Dec 14, 2024

Sure @vinaayakha, but when you try to import it put it under a try-except block. For example

try:
    from firecrawl import FirecrawlApp
except ImportError:
    raise ImportError("`firecrawl-py` not installed. Please install using `pip install firecrawl-py`")

Don't update the pyproject.toml file or the requirements.txt file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants