diff --git a/js/Announcer.ts b/js/Announcer.ts index c5ee19a..1383a77 100644 --- a/js/Announcer.ts +++ b/js/Announcer.ts @@ -111,8 +111,6 @@ abstract class Announcer extends PhetioObject { } public static AnnouncerIO = new IOType( 'AnnouncerIO', { - - // @ts-ignore https://github.com/phetsims/tandem/issues/261 valueType: Announcer, documentation: 'Announces text to a specific browser technology (like aria-live or web speech)' } ); diff --git a/js/ResponsePacket.ts b/js/ResponsePacket.ts index ee6bc41..f05a76a 100644 --- a/js/ResponsePacket.ts +++ b/js/ResponsePacket.ts @@ -183,8 +183,6 @@ class ResponsePacket { // Map VoicingResponse -> ResolvedResponse (resolve functions and Properties to their values) public static getResponseText( response: VoicingResponse ): ResolvedResponse { - - // @ts-ignore This maps to ensuring we cover the TReadOnlyProperty case, but not in a type safe way, https://github.com/phetsims/scenery/issues/1442 return response instanceof ReadOnlyProperty || response instanceof TinyProperty ? response.value : typeof response === 'function' ? response() : response; } diff --git a/js/ResponsePatternCollection.ts b/js/ResponsePatternCollection.ts index 87d868e..f565fdc 100644 --- a/js/ResponsePatternCollection.ts +++ b/js/ResponsePatternCollection.ts @@ -103,7 +103,7 @@ class ResponsePatternCollection { // TODO: Not sure how to get rid of this index signature error. I was looking at assertion signatures in links below, see https://github.com/phetsims/tambo/issues/160 // https://stackoverflow.com/questions/56568423/typescript-no-index-signature-with-a-parameter-of-type-string-was-found-on-ty // https://www.carlrippon.com/typescript-assertion-signatures/ - // @ts-ignore + // @ts-expect-error const patternString = this[ key ]; assert && assert( patternString, `no pattern string found for key ${key}` ); return patternString; diff --git a/js/SpeechSynthesisParentPolyfill.ts b/js/SpeechSynthesisParentPolyfill.ts index 1ebc078..c50d0de 100644 --- a/js/SpeechSynthesisParentPolyfill.ts +++ b/js/SpeechSynthesisParentPolyfill.ts @@ -25,13 +25,13 @@ const SpeechSynthesisParentPolyfill = { assert && assert( window.parent, 'This polyfill requires a parent frame implementation of SpeechSynthesis.' ); - // @ts-ignore - Don't judge me TypeScript... + // @ts-expect-error - Don't judge me TypeScript... window.SpeechSynthesis = window.parent.SpeechSynthesis; - // @ts-ignore - Don't judge me TypeScript... + // @ts-expect-error - Don't judge me TypeScript... window.speechSynthesis = new window.parent.SpeechSynthesis(); - // @ts-ignore - Don't judge me TypeScript... + // @ts-expect-error - Don't judge me TypeScript... window.SpeechSynthesisUtterance = window.parent.SpeechSynthesisUtterance; } }; diff --git a/js/Utterance.ts b/js/Utterance.ts index 26ea5c3..0f6c31a 100644 --- a/js/Utterance.ts +++ b/js/Utterance.ts @@ -363,7 +363,7 @@ class Utterance extends Disposable implements FeatureSpecificAnnouncingControlPr alert = alertable.value; } else { - // @ts-ignore + // @ts-expect-error alert = alertable; } return alert; diff --git a/js/UtteranceQueueTests.ts b/js/UtteranceQueueTests.ts index 1cd40ca..a4cff13 100644 --- a/js/UtteranceQueueTests.ts +++ b/js/UtteranceQueueTests.ts @@ -26,7 +26,7 @@ const VOICING_UTTERANCE_INTERVAL = 125; // When we want to add a little time to make that an interval has completed. const TIMING_BUFFER = VOICING_UTTERANCE_INTERVAL + 50; -// @ts-ignore we don't want to expose the constructor of this singleton just for unit tests. +// @ts-expect-error we don't want to expose the constructor of this singleton just for unit tests. const testVoicingManager = new voicingManager.constructor(); const testVoicingUtteranceQueue = new UtteranceQueue( testVoicingManager ); diff --git a/js/utterance-queue-main.ts b/js/utterance-queue-main.ts index f6fe219..a971ed4 100644 --- a/js/utterance-queue-main.ts +++ b/js/utterance-queue-main.ts @@ -7,12 +7,12 @@ import utteranceQueue from './main.js'; // eslint-disable-line default-import-ma ( function() { - // @ts-ignore + // @ts-expect-error window.axon = axon; - // @ts-ignore + // @ts-expect-error window.phetCore = phetCore; - // @ts-ignore + // @ts-expect-error window.utteranceQueue = utteranceQueue; } ); \ No newline at end of file