Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate duplication identified by jsinspect #72

Closed
pixelzoom opened this issue Oct 3, 2016 · 1 comment
Closed

investigate duplication identified by jsinspect #72

pixelzoom opened this issue Oct 3, 2016 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 3, 2016

Code review #52, checklist item:

jsinspect (with default config) identified 42 items. Some of these look like they warrant closer inspection. E.g. ItemRateNode contains duplication that should be factored out in options to NumberPicker.

@pixelzoom
Copy link
Contributor Author

No plans to address this in old implementation. New implementation will be tested for duplication as part of standard checklist. Closing as "will not fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant