Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Translation not submitted' error shown #343

Closed
Tracked by #931
Nancy-Salpepi opened this issue Dec 21, 2022 · 5 comments
Closed
Tracked by #931

'Translation not submitted' error shown #343

Nancy-Salpepi opened this issue Dec 21, 2022 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Dec 21, 2022

For phetsims/qa#869 on macOS 13 + safari, after pressing the "Publish" button, and then "OK" -- I get an error message:
Screenshot 2022-12-21 at 4 54 57 PM

But when I go to babel, the translation is there. Here it is for Mean, Share, and Balance:

Screenshot 2022-12-21 at 4 58 33 PM

@liammulh
Copy link
Member

This is actually behaving consistently with the config. The send build request flag is set to false. This means the strings will be committed, but the build request for the sim won't be sent to the build server.

However, I understand why this error message is confusing.

If we were to have booleans for stringsWereCommitted, buildRequestSent, sendBuildRequests, and performStringCommits on the client when we're about to display this message, we could have an accurate message.

We could say, "hey, we're not sending build requests, but your strings were committed to babel," for example.

@liammulh
Copy link
Member

liammulh commented Mar 5, 2023

This is not high-priority for me right now. I will reassign when I get to this.

@liammulh
Copy link
Member

This should be fixed in 156697d.

@Nancy-Salpepi
Copy link
Author

This looks good in phetsims/qa#931. closing.

@liammulh
Copy link
Member

Deployed in 6021626 (2.0.7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants