Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and investigate sharing of camera input and Bluetooth features #301

Open
brettfiedler opened this issue Dec 22, 2022 · 8 comments

Comments

@brettfiedler
Copy link
Contributor

brettfiedler commented Dec 22, 2022

[Placeholder comment]

Update when decision to publish or place prototypes of this feature on the website is made. Self-assigning.

@brettfiedler
Copy link
Contributor Author

We will not be publishing with BT connection as a tested feature. We would, however, like to investigate cleaning up cameraInput=hands and the Bluetooth feature to share as inclusive feature prototypes. If time allows and we find an easy way to do so, we'd also like to share the OpenCV implementation, noting that without significant work, the interface will not be accessible. We will also likely need to package it and host it somewhere since the sim itself lives in a container.

Changing the title of this issue and putting all of this discussion in one place. This should not block publication.

@brettfiedler brettfiedler changed the title Clean up code and assemble publication material for Tangible publication Clean up and investigate sharing of camera input and Bluetooth features Jan 5, 2023
@brettfiedler
Copy link
Contributor Author

@BLFiedler:

  • List documentation needs for each feature.

@jessegreenberg:
Question: Can you quickly indicate what would need to happen to create a single shareable link each for 1.) Bluetooth-enabled sim (assuming it is structured like Scott's tangible), 2.) Camera Input: Hands, and 3.) OpenCV marker tracking

@brettfiedler brettfiedler added the type:question Further information is requested label Jan 5, 2023
@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 5, 2023

Sure!

  • Camera Input: Hands: Easy to publish right in sim. Are there any settings or new design requirements to get it working in a practical way? The work would be to get it working in a more presentable way. Code is very prototypy and could use cleanup.
  • Bluetooth: Easy to publish right in sim, but I don't know how to test it to make sure it is compatible with the latest devices and working well. The code is not in a good state and needs some cleanup if we are going to keep it.
  • Marker Tracking: I don't know how to publish or share this. We should discuss as a team what kind of prototype to share. We could put a link up to our prototype wrapper somehow (https://phet-dev.colorado.edu/html/jg-tests/opencv-test/). Maybe we could clean it up and have it hosted somewhere. Or we could look into building OpenCV right into the sim so there is no wrapper? That would be a big project and could 3-6 months of full development time. ( I am imagining designing and implementing the UI of the wrapper in the sim, figuring out how to get OpenCV as a PhET code dependency, other new features that are identified as we create this new thing).

@jessegreenberg jessegreenberg removed their assignment Jan 5, 2023
@brettfiedler
Copy link
Contributor Author

brettfiedler commented Jan 24, 2023

WebBluetooth requires BLE. Link some documentation when I create the tips info for connecting a device

@brettfiedler
Copy link
Contributor Author

Let's schedule a test with Scott to verify our latest code still works to connect to the TMQ.

@brettfiedler
Copy link
Contributor Author

We'll send a dev version to Scott when @jessegreenberg has made the changes he was intending to. We can ask Scott to video demo or meet with him.

@jessegreenberg
Copy link
Contributor

I think I was assigned to reach out to Scott but that part is done. Assigning back to @BLFiedler.

@brettfiedler
Copy link
Contributor Author

We're deprioritizing both BLE and CI:H features and related issues while we get a QA ready build of the sim ready. #315 #258

The current plan is to pick back up on those issues (possibly even this week) when there is a QA ready build. We'll present both features on a dev version after publication, including links to documentation hosted on OSF

  • Document: Connecting Quadrilateral to a Tangible Quadrilateral through BLE
  • List of electronics used for latest SmartTMQ build
  • 3D printer files for SmartTMQ build
  • Microcontroller code for SmartTMQ build

@brettfiedler brettfiedler removed the type:question Further information is requested label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants