-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify sims that have Safari 17.4 quadratic rendering problem #1069
Comments
@KatieWoe You'll probably want to check with @kathy-phet to confirm that this is a project worth doing, or whether to wait until problems are reported. This is obviously a huge amount of stuff to test. And without assistance from the sim developer, it's not at all clear what should even be tested. For the sims that I'm familar with, I've provided details above. It's also possible that @jonathanolson might be able to prune this task down a bit. Also worth following up on where @jonathanolson is with reporting this problem to the WebKit team for phetsims/scenery#1628, and whether a fix for Safari 17.4 is forthcoming. |
QA is done |
@KatieWoe Can you please summarize what was tested, and what the results were?
And did someone follow up on this? |
Sorry, I missed this earlier. We looked through the sims in the Safari browser and focused in particular on graphs, changing lines, the items described such as probes, and looked for graphical issues and disappearing elements. I don't believe we encountered similar issues, or they would have been recorded. |
👍🏻 |
In phetsims/graphing-quadratics#206, @Nancy-Salpepi discovered a bug in Safari 17.4 on Apple chips. That bug was related to using SVG to draw quadratic curves, and was resolved for graphing-quadratics.
The bug is being tracked more generally in phetsims/scenery#1628.
In phetsims/graphing-quadratics#206 (comment), @kathy-phet said:
According to @jonathanolson, sims that use these methods of
kite.Shape
are liable to have this problem:Sims that call one or more of those methods directly include:
One or more of those methods are also used in these scenery-phet UI components:
BicyclePumpNode
(used to draw the pump handle and front edge)ProbeNode
ReturnButton / ReturnIcon
The text was updated successfully, but these errors were encountered: