From 648c36b627af13ef5ff75d949096fc4f5f18279a Mon Sep 17 00:00:00 2001 From: matthew-blackman Date: Fri, 1 Mar 2024 10:18:47 -0500 Subject: [PATCH] Update air pressure needle rotation - see https://github.com/phetsims/projectile-data-lab/issues/7 --- js/common-vsm/view/CustomLauncherNode.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/js/common-vsm/view/CustomLauncherNode.ts b/js/common-vsm/view/CustomLauncherNode.ts index 8d7c5e45..3ccdade9 100644 --- a/js/common-vsm/view/CustomLauncherNode.ts +++ b/js/common-vsm/view/CustomLauncherNode.ts @@ -68,8 +68,11 @@ export default class CustomLauncherNode extends LauncherNode { const isLauncherCustomProperty = DerivedProperty.valueEqualsConstant( mysteryOrCustomProperty, 'custom' ); - const pressureNeedleIcon = new Image( pressureNeedle_png, { x: -13.5, y: -40 } ); - const pressureNeedleNode = new Node( { children: [ pressureNeedleIcon ] } ); + const pressureNeedleNode = new Node( { + children: [ + new Image( pressureNeedle_png, { x: -13.5, y: -40 } ) + ], rotation: -Math.PI / 2 + } ); const launcherTypeIconContainer = new Node( { x: -0.7 * BARREL_LENGTH_BEFORE_ORIGIN, @@ -158,8 +161,8 @@ export default class CustomLauncherNode extends LauncherNode { pressureNeedleNode.visible = launcherType === PRESSURE; } ); - latestLaunchSpeedProperty.link( launchSpeed => { - const maxAngle = 80; + latestLaunchSpeedProperty.lazyLink( launchSpeed => { + const maxAngle = 120; const meanSpeed = launcherMechanismProperty.value.speedMeanProperty.value; const maxSpeed = 30; const needleDeltaRotation = maxAngle * ( launchSpeed - meanSpeed ) / ( maxSpeed - meanSpeed );