setting maxWidth for listboxParent causes scale/position problem

[pixelzoom]

See phetsims/sun#542.

[pixelzoom]

Fixed in the above commit.

[pixelzoom]

Looks like this problem (phetsims/sun#542) is reoccurring. @arouinfar reported on Slack:

I was looking at some examples of how ComboBox handles i18n, and I noticed that the latest published version of pH Scale is not handling stringTest=long very gracefully. The problem started appearing in 1.3.0, but is not present in master. With the PhET-iO work going on, I doubt this would be the time to fix it up in a maintenance release, but I wanted to make you aware (if you weren’t already). It isn’t something sim-breaking, just not very pretty.

[pixelzoom]

@arouinfar I I could not reproduce this in master, so I re-read your description above. You said " the latest published version". And that's a fact -- it's broken in the latest published version (1.3.4), which is on the 1.3 release branch. This issue was marked "status:fixed-awaiting-deploy" because it had been fixed in master, and needs to be tested the next time we create a release branch. There is no plan to patch it in the 1.3 branch.

If for some reason you can re-produce this in master, please let me know.

[arouinfar]

I never saw the problem on master, only in versions 1.3.0-1.3.4.

[pixelzoom]

To regression test:

Run the sim normally, and confirm that the listbox is the same width as the left portion of the combo box button (the part of the button that displays the selected value), and left-aligned with the button, as in this screenshot:

Run the sim with ?stringTest=long, and confirm that the listbox is still the same width as the left portion of the combo box button, and left-aligned with the button, as in this screenshot:

[KatieWoe]

Looks good in phetsims/qa#514